On Sun, Mar 11, 2018 at 3:58 PM, Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> wrote: > On Sun, Mar 11, 2018 at 02:22:49PM -0400, Nico Kadel-Garcia wrote: >> On Sun, Mar 11, 2018 at 2:21 PM, Nico Kadel-Garcia <nka...@gmail.com> wrote: >> > On Sun, Mar 11, 2018 at 10:25 AM, Zbigniew Jędrzejewski-Szmek >> > <zbys...@in.waw.pl> wrote: >> >> On Sun, Mar 11, 2018 at 10:04:25AM -0400, Neal Gompa wrote: >> >>> On Sun, Mar 11, 2018 at 10:01 AM, Zbigniew Jędrzejewski-Szmek >> >>> <zbys...@in.waw.pl> wrote: >> > >> >>> > I wanted to submit a PR for this, but I wasn't sure what the proper >> >>> > location is. /usr/lib/rpm/redhat/macros (from redhat-rpm-config) or >> >>> > /usr/lib/rpm/macros.d/macros.fedora (from fedora-rpm-macros)? >> >>> > >> >>> >> >>> redhat-rpm-config is the right place. It belongs in >> >>> /usr/lib/rpm/redhat/macros. >> >> >> >> https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/22 >> > >> > So you're not actually adding a feature, as the pull request seems to >> > describe. You're simply resetting the default from "0" to "numerical >> > equivalent of 2 years", for all applications. Why not simply alter it >> > for kernel.ll other packages unmodified? >> >> That came out somewhat garbled. >> >> Why not simply alter it for kernel.spec, and leave alone other >> packages that may use the same macro? > This seems to be misunderstanding. This has nothing to do with kernel.spec > in particular. That PR trims _all_ changelogs, on purpose.
Ahh, that's more clear. I also saw the note and whitespace patch mentioning "kernel-rpm-macros". If I were writing such a change from scratch, I'd set the log entry to say "Set default changelog retention to 2 years", rather than "Trim changelog entries older than two years", because the code is not actually in your patch. only the change of the default entry. But it's not my package, I thought I'd noticed an inconsistency that is nowhere near size of what I understood to be a possible issue. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
