On 25/05/17 11:46, Richard W.M. Jones wrote:
On Thu, May 25, 2017 at 11:17:21AM +0100, Sérgio Basto wrote:
On Thu, 2017-05-25 at 10:36 +0100, Richard W.M. Jones wrote:
fedora-review prints this in the ‘Issues’ section of the report:
‘- Package contains BR: python2-devel or python3-devel’
This has happened on a couple of reviews I have done recently. There
is no other information given about what this means or why it's bad.
Both were Python packages and the Python package guidelines mention
that you *should* have BR: python2-devel / python3-devel
(https://fedoraproject.org/wiki/Packaging:Python#BuildRequires)
So .. what does it mean?
https://pagure.io/FedoraReview/issue/273
(...) Message should say , IMHO, "do not use BR: python-devel use
instead BR: python2-devel or python3-devel " . It clarifies what is the
problem.
Fair enough, although in both of my cases ‘BR: python-devel’ was _not_
being used.
Yes that suggested text is no better really.
The test is checking that either python2-devel or python3-devel is being
required - it doesn't consider python-devel at all so mentioning that in
the message would be very misleading.
So it will error unless python2-devel or python3-devel is required but
the message is phrased in terms of what is expected rather than what is
actually present - so it's not saying the package contains X rather it
is saying the package should contain X (and doesn't).
Tom
--
Tom Hughes (t...@compton.nu)
http://compton.nu/
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
