On Thu, Apr 13, 2017 at 10:39:21PM +0100, Richard W.M. Jones wrote:
> On Thu, Apr 13, 2017 at 10:34:41PM +0100, Richard W.M. Jones wrote:
> > On Thu, Apr 13, 2017 at 10:58:20PM +0200, Mark Wielaard wrote:
> > > As Omair pointed out the check should be skipped for any non-executable
> > > file. So check
> >
> > $ ls -l /usr/lib64/afl/afl-llvm-rt-64.o
> > -rwxr-xr-x. 1 root root 5880 Apr 13 18:15 /usr/lib64/afl/afl-llvm-rt-64.o
> >
> > OK, that's interesting. I'll see what happens if it's not executable.
> > Maybe that is the solution.
>
> Indeed that does fix it, thanks Mark & Omair.
Great!
BTW. The reason they are executable are these lines in the upstream
Makefile:
if [ -f afl-llvm-rt-32.o ]; then set -e; install -m 755
afl-llvm-rt-32.o $${DESTDIR}$(HELPER_PATH); fi
if [ -f afl-llvm-rt-64.o ]; then set -e; install -m 755
afl-llvm-rt-64.o $${DESTDIR}$(HELPER_PATH); fi
You might want to sent a patch upstream to change that to -m 644.
Or ask if there is a reason the object files are installed executable.
Cheers,
Mark
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
