Hi,
On 14-02-17 14:24, Stanislav Kozina wrote:
Hi,
On 13-02-17 14:27, Stanislav Kozina wrote:
Hello Hans,
(adding some more folks on CC..)
You've correctly mentioned one of the problems with the kmod tools, that there
are several versions in a various stages of loneliness. The other problem is
that the usage of them is not trivial, eg. the %kernel_module_package macro (as
the main user of the kmodtool) is quite complicated and limiting in the options
you might need for the kmod build.
For this reason we have recently developed a new tool which can be used to
build a kmod. It doesn't use anything from the kernel-module-macros package,
instead, it helps you to create a correct directory structure, generate a .spec
file and package your kernel modules using this .spec file. This should make
the kmod build much more self-contained. The tool has been recently also added
to the Fedora COPR repository:
https://copr.fedorainfracloud.org/coprs/ersin/ddiskit/
Because of the current status of the content of the kernel-module-macros
package I think it would be better to just remove it from Fedora completely.
That sounds like a fine plan.
The ddiskit v.3 should be used as a replacement, we plan to propose it as a
Fedora base package soon
As explained by Neal Gompa 3th part repos have invested a lot
of effort into kmodtool and that will likely stay the preferred
way for them to package modules going forward at least for the
short term. So I think it would be good to:
Sure, that might be. I'm not a big fan of generating sub-package parts of the
.spec file via script, but I totally understand it might work for others.
1) Drop the ancient kmodtool / entire kernel-module-macros package from
redhat-rpm-config
2) Move kmodtool from rpmfusion to Fedora proper (where it can be shared with
other 3th
party repos) and extend it where necessary for other repo use-cases
3) Get ddiskit packaged into Fedora proper and promote people to use it for new
kernel module
packages / convert existing packages over (if the maintainer wishes)
Sounds like a good plan. I'd also add a docs step:
4) Make it clear that the kmodtool is required by akmod (so far). ddiskit can
be used to package binary modules without recompilation on each new kernel
release.
Ok, adding that 4th step is fine by me, the question is where do we put
these docs though ?
Technically, the ddiskit just generates the .spec file for you so you don't
need to have hooks to kmodtool there. Of course it could be enhanced to
generate the akmod subpackage code as well.
Think of this as how yum and dnf co-existed for a while.
> The kernel module support from the /usr/lib/rpm/redhat/find-provides script
might also be removed, together with the /usr/sbin/weak-modules script.
I'm mostly coordinating things here, I'm not an expert on kernel module
packaging,
so I'll let others weigh in if that is a good idea, specifically it would be
good
to know if existing kernel (module) packages depend on this ?
The kernel package isn't calling weak-modules at all:
$ grep -i weak-modules kernel.spec
The RPM Fusion doesn't call it either:
$ grep weak-modules bin/kmodtool
Thinking about it, currently in Fedora it doesn't make sense for any of these
sides to call weak-modules, as the recommended procedure is to rebuild the
modules with the release of each new kernel. That's why I'm proposing to remove
it.
As said I'm fine with removing it, just making sure doing so does not break
anything.
Regards,
Hans
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
