On 08/02/17 00:14, Sérgio Basto wrote:
On Ter, 2017-02-07 at 18:56 -0500, Stephen John Smoogen wrote:
On 7 February 2017 at 18:39, Sérgio Basto <ser...@serjux.com> wrote:
Hi,
On Ter, 2017-02-07 at 22:32 +0100, Marek Polacek wrote:
some C++ FE changes (especially the "Fix type-dependence
and the current instantiation" changes made the compiler to
reject
invalid code
that had previously been accepted, plus invalid conversions with
'\0'
are now
rejected)
Thanks for exhaustive explanation .
I have this case, how we fix ?
src/rtphint.cpp:342:35: error: ISO C++ forbids comparison between
pointer and integer [-fpermissive]
if (pSlash != '\0') {
Someone would need to see more code than that. How is pSlash
declared?
What is the context of the code you have quoted?
https://github.com/sergiomb2/libmp4v2/blob/master/src/rtphint.cpp#L342
So it's exactly as I said. That code is just wrong and should be:
if (*pSlash != '\0') {
As it stands the body of that if will always execute and when there are
no encoding parameters ppEncodingParams will be returned as a pointer to
an empty string rather than as a null pointer.
Tom
--
Tom Hughes (t...@compton.nu)
http://compton.nu/
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
