On Mon, Oct 17, 2016 at 12:45:30PM -0400, Matthew Miller wrote: > On Mon, Oct 17, 2016 at 04:38:28PM +0000, Zbigniew Jędrzejewski-Szmek wrote: > > It's a good principle to require both tests and fixes required for > > those tests to pass to be submitted and merged as a single pull request. > > I'd love to see a PR that adds a test for one of my packages, exposes > > some bugs, but immediately fixes any fallout. I would be less thrilled > > to have tests committed which will fail on the next rebuild, leaving me to > > fix the package (or manually override the tests). > > As I'm imaginging it, tests added in this way would be non-blocking, > and would be expected to pass initially.
"feel good" tests ;) But seriously, why should people write only tests which pass? Zbyszek _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
