On Fri, 2016-09-09 at 16:54 +0200, Igor Gnatenko wrote: Problem with tito as it doesn't really do proper archive for build/release and doesn't work properly in many cases: 1. Version is specified in spec -> all builds will be unordered. Example: Version: 2.0.0 -> 2.0.0-1.git.tree-ish
I don't have any problem with this at all. For my test builds I don't use tito.release.KojiGitReleaser but rather tito.release.KojiReleaser which produces builds named like: builder-6.14-1.git.6.05be4b1.fc24 builder-6.14-1.git.7.40346c1.fc24 builder-6.14-1.git.8.c448a30.fc24 ... where the '.6', '.7', '.'8' following represents the number of commits since the last "tito tag" operation. I only get burned when redo one of those "steps" with "git commit --fixup" followed later by "git rebase -i --autosquash". However, by that time I'm finalizing a branch and can live with a reinstall vs upgrade. 2. Replaces archive. Source: https://.../%{name}-%{version}.tar.gz is 404 as tito creates releases in %{name}-%{version}-X where X is release. If we are talking about Github, then even you change URL to proper it still doesn't work because %(auto)setup fails, as github generates archive in %{name}-%{name}-%{version}-X format. I'm not 100% sure I follow you here, but I suspect I get away with this because all my spec's have: Source0: %{name}-%{version}.tar.gz Granted, this would never fly in Fedora proper, but for private work it suits me fine. I otherwise attempt to adhere to FPG as much as possible as it generally makes life simpler. X. Requires some files in upstream repo I'm not sure I follow here either, but as the author and packager for my projects, I actually prefer that our Git repo has everything needed, spec, Makefile, etc. right there. The only part that makes me cringe is the fact that Makefile is duped all over the place. I hate dupes and strive for DRY because eventually they all need to change. I would not recommend using tito. I would recommend to have spec in upstream ONLY for reference, but have proper Fedora ones in our dist-git. In my case (but perhaps not Mr. Weimer's) is that I don't have to be proper per Fedora. FWIW, I found tito to be a godsend for bringing ease to my situation. That all said, I'm very curious how your rpm-gitoverlay helps exactly. I've found a solution that works for me, but I hammered out a solution without as broad an understanding of how Fedora is built as I have now -- and I'm certain my current understanding is probably woefully lacking. Is rgo something that could be used with our private Koji setup? My quick glance at the code leads me it's suited for copr or rpmbuild only. -- John Florian <john.flor...@dart.biz<mailto:john.flor...@dart.biz>>
-- devel mailing list devel@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
