Looks good to me. Thanks for fixing this, Ann. Reviewed-by: Sunny Wang <[email protected]>
-----Original Message----- From: [email protected] <[email protected]> On Behalf Of Ann Cheng via groups.io Sent: Friday, November 15, 2024 8:19 AM To: [email protected] Cc: G Edhaya Chandran <[email protected]>; Barton Gao <[email protected]>; Carolyn Gjertsen <[email protected]> Subject: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4847 EFI_ACCESS_DENIED (The action violated a system policy) is an acceptable status for ExtractConfig in UEFI specification. SCT now marks the test case as a warning instead of failure, when EFI_ACCESS_DENIED is returned. Cc: G Edhaya Chandran <[email protected]> Cc: Barton Gao <[email protected]> Cc: Carolyn Gjertsen <[email protected]> Signed-off-by: Ann Cheng <[email protected]> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c index fedccb382f81..b1419bed36dc 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/HIIConfigAccess/BlackBoxTest/HIIConfigAccessBBTestFunction.c @@ -328,8 +328,8 @@ BBTestExtractConfigFunctionTestCheckpoint1 ( } else { gtBS->FreePool (Results); } - } else if (EFI_OUT_OF_RESOURCES == Status) { - AssertionType = EFI_TEST_ASSERTION_WARNING; + } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) { + AssertionType = EFI_TEST_ASSERTION_WARNING; }else { AssertionType = EFI_TEST_ASSERTION_FAILED; } @@ -385,7 +385,7 @@ BBTestExtractConfigFunctionTestCheckpoint1 ( } gtBS->FreePool (Results); } - } else if (EFI_OUT_OF_RESOURCES == Status) { + } else if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) { AssertionType = EFI_TEST_ASSERTION_WARNING; }else { AssertionType = EFI_TEST_ASSERTION_FAILED; @@ -445,7 +445,7 @@ BBTestExtractConfigFunctionTestCheckpoint2 ( &Results ); - if (EFI_OUT_OF_RESOURCES == Status) { + if ( (EFI_OUT_OF_RESOURCES == Status) || (EFI_ACCESS_DENIED == Status) ) { AssertionType = EFI_TEST_ASSERTION_WARNING; } else if ((EFI_NOT_FOUND == Status) && (Progress == NULL) && (Results == NULL)) { AssertionType = EFI_TEST_ASSERTION_PASSED; -- 2.34.1 IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120806): https://edk2.groups.io/g/devel/message/120806 Mute This Topic: https://groups.io/mt/109648112/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
