The DevicePathBBTest wrongly flags the failure for a valid VLAN device path node. For e.g. value 4040 The range check for vlanId is corrected to fix this issue.
https://bugzilla.tianocore.org/show_bug.cgi?id=4710 Signed-off-by: G Edhaya Chandran <edhaya.chand...@arm.com> --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c index c8757e958a22..dbf39b77dd01 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePath/BlackBoxTest/DevicePathBBTestFunction.c @@ -682,7 +682,7 @@ BBTestDevicePathNodeConformanceAutoTest ( // else if ((Type == 3) && (SubType == 20)) { Vlan = (VLAN_DEVICE_PATH *) DevicePath; - if (Vlan->VlanId > 4094 || Vlan->VlanId) { + if (Vlan->VlanId > 4094 || Vlan->VlanId < 1) { AssertionType = EFI_TEST_ASSERTION_FAILED; } else { AssertionType = EFI_TEST_ASSERTION_PASSED; -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120757): https://edk2.groups.io/g/devel/message/120757 Mute This Topic: https://groups.io/mt/109452250/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
