On Fri, Aug 30, 2024 at 5:46 PM Sami Mujawar via Groups.Io
<sami.mujawar=arm....@groups.io> wrote:
>
> Hi Ard,
>
> Thank you for this patch.
>
> These changes look good to me.
>
> Reviewed-by: Sami Mujawar <sami.muja...@arm.com>
>

Thanks

> In addition to this patch I required the following changes for the FVP to 
> boot to the UEFI shell.
>
> edk2 repo:
> -----------
> diff --git a/ArmPlatformPkg/PeilessSec/PeilessSec.inf 
> b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> index 7ceeb74f69f2..d652b72e46b9 100644
> --- a/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> +++ b/ArmPlatformPkg/PeilessSec/PeilessSec.inf
> @@ -43,6 +43,7 @@ [LibraryClasses]
>    DebugAgentLib
>    DebugLib
>    HobLib
> +  LzmaDecompressLib
>    MemoryInitPeiLib
>    PerformanceLib
>    PlatformPeiLib
>
>
> edk2-platforms repo:
> ---------------------
> diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc 
> b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> index 931eff2355d4..a299d7ed559a 100644
> --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc
> @@ -194,6 +194,7 @@ [LibraryClasses.common.SEC]
>  !ifdef $(EDK2_SKIP_PEICORE)
>    PrePiLib|EmbeddedPkg/Library/PrePiLib/PrePiLib.inf
>    
> ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> +  
> LzmaDecompressLib|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>    
> MemoryAllocationLib|EmbeddedPkg/Library/PrePiMemoryAllocationLib/PrePiMemoryAllocationLib.inf
>    HobLib|EmbeddedPkg/Library/PrePiHobLib/PrePiHobLib.inf
>    
> PrePiHobListPointerLib|ArmPlatformPkg/Library/PrePiHobListPointerLib/PrePiHobListPointerLib.inf
>
> Without the above change the "SECTION GUIDED 
> EE4E5898-3914-4259-9D6E-DC7BD79403CF" is not found, see 
> https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.fdf#L250
>

My bad. Could you please check whether the below works as well?

--- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
+++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
@@ -230,6 +230,7 @@ [Components.common]
   # UEFI is placed in RAM by bootloader
   ArmPlatformPkg/PeilessSec/PeilessSec.inf {
     <LibraryClasses>
+      
NULL|MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
       
ArmPlatformLib|Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf
   }
 !else


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120449): https://edk2.groups.io/g/devel/message/120449
Mute This Topic: https://groups.io/mt/108128468/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to