On Wed, 8 May 2024 at 11:21, Pete Batard <p...@akeo.ie> wrote: > > Hi Ard, > > Thanks for the quick review. > > Note that as opposed to the previous one you referenced, that patches > both the .S and the .asm, my submission only patches the .asm, so it's > probably better to use Adam Liu's for integration (who was the first to > propose a fix anyway). >
Yeah, we'll end up merging the other patch, most likely. But thanks for reminding us of this issue - it does need fixing. > As to your other question, see inline: > > On 2024.05.08 10:08, Ard Biesheuvel wrote: > > On Wed, 8 May 2024 at 11:07, Ard Biesheuvel <a...@kernel.org> wrote: > >> > >> On Wed, 8 May 2024 at 10:52, Pete Batard <p...@akeo.ie> wrote: > >>> > >>> Commit 80bbea192aa44ab664ba8be29ac06c83f246e99c introduced a regression > >>> resulting in 'error A2023: undefined symbol: InternalAssertJumpBuffer' > >>> when compling MdePkg for AARCH64 with Visual Studio. > >>> Fix this by adding the relevant EXTERN reference. > >>> > >>> Signed-off-by: Pete Batard <p...@akeo.ie> > >>> Cc: Leif Lindholm <quic_llind...@quicinc.com> > >>> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > >> > >> Reviewed-by: Ard Biesheuvel <a...@kernel.org> > >> > >> Note that the same issue has been raised two months ago, and a similar > >> fix proposed > >> > >> https://openfw.io/edk2-devel/20240320025130.599086-1-adam....@tw.synaptics.com/ > >> > >> so IMHO this qualifies for inclusion in the stable tag. > >> > > > > BTW the existence of this issue appears to imply that the VS RELEASE > > build does not #define MDEPKG_NDEBUG. Is that an oversight? > > In my testing with VS2022 (with '-b RELEASE'), adding: > > #ifdef MDEPKG_NDEBUG > #error MDEPKG_NDEBUG is defined > #endif > > to SetJump.c does produce the expected: > > d:\edk2\MdePkg\Library\BaseLib\SetJump.c(12): fatal error C1189: #error: > MDEPKG_NDEBUG is defined > > So as far as I can tell, MDEPKG_NDEBUG is properly defined. > The reference to InternalAssertJumpBuffer was intended to only be emitted if MDEPKG_NDEBUG is not defined, but this appears to be broken too. MDEPKG_NDEBUG is added to the CC flags only, never to the PP flags - given that a #define is fundamentally a PP flag, it would be better if all -D flags were carried in a separate variable that gets added to both, but this is future refactoring that I won't get around to myself, most probably. Leif, any thoughts? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118670): https://edk2.groups.io/g/devel/message/118670 Mute This Topic: https://groups.io/mt/105977470/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
