Felix: I understand your point. I would suggest to directly add PI_SPECIFICATION_VERSION definition, and update PEI/DXE/SMM version to align with it. Original PEI/DXE/SMM minor and major version definitions are still kept now.
Thanks Liming > -----邮件原件----- > 发件人: Felix Polyudov <fel...@ami.com> > 发送时间: 2024年5月1日 6:35 > 收件人: gaoliming <gaolim...@byosoft.com.cn>; Sachin Ganesh > <sachingan...@ami.com>; devel@edk2.groups.io > 抄送: zhiguang....@intel.com; michael.d.kin...@intel.com; > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen....@intel.com; > erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com; > Dhanaraj V <vdhana...@ami.com> > 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI > 2.10 and PI 1.8 Specification > > Liming, > > In PI 1.8 macros for major and minor versions have been replaced with a > single revision macro combining both version elements. > Refer to: > PEI: > https://uefi.org/specs/PI/1.8/V1_PEI_Services_Table.html#related-definition > s > DXE: https://uefi.org/specs/PI/1.8/V2_UEFI_System_Table.html#dxe-services > MM: > https://uefi.org/specs/PI/1.8/V4_Management_Mode_System_Table.html#e > fi-mm-system-table > > If patch is updated to literally follow the spec, the following macros will be > removed: > PEI_SPECIFICATION_MAJOR_REVISION > PEI_SPECIFICATION_MINOR_REVISION > DXE_SPECIFICATION_MAJOR_REVISION > DXE_SPECIFICATION_MINOR_REVISION > MM_SPECIFICATION_MAJOR_REVISION > MM_SPECIFICATION_MINOR_REVISION > > These macros exist for a long time, so their removal can break some code in > the downstream projects. > That's why we thought it would be safer to honor the spirit of the spec > without following it literally. > > Let us know if you want us to update the patch to match the spec. > > -----Original Message----- > From: gaoliming <gaolim...@byosoft.com.cn> > Sent: Friday, April 26, 2024 5:23 AM > To: Sachin Ganesh <sachingan...@ami.com>; Felix Polyudov > <fel...@ami.com>; devel@edk2.groups.io > Cc: zhiguang....@intel.com; michael.d.kin...@intel.com; > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen....@intel.com; > erdemak...@google.com; min.m...@intel.com; thomas.lenda...@amd.com; > Dhanaraj V <vdhana...@ami.com> > Subject: 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on > UEFI 2.10 and PI 1.8 Specification > > Felix and Sachin: > I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest > public PI 1.8A. So, this change may not be added now. > > Thanks > Liming > > -----邮件原件----- > > 发件人: Sachin Ganesh <sachingan...@ami.com> > > 发送时间: 2024年4月25日 17:57 > > 收件人: Felix Polyudov <fel...@ami.com>; gaoliming > > <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > > 抄送: zhiguang....@intel.com; michael.d.kin...@intel.com; > > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen....@intel.com; > > erdemak...@google.com; min.m...@intel.com; > thomas.lenda...@amd.com; > > Dhanaraj V <vdhana...@ami.com> > > 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI > > 2.10 and PI 1.8 Specification > > > > Hi Felix/ Liming, > > > > Thank you for your comments. Patch 6 has been updated to only focus on > > consolidating the revision macros. > > > > Patch Link: > > > https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2 > 52 > > > C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0% > > 2C105721897 > > PR Link: https://github.com/tianocore/edk2/pull/5569 > > > > Thank you, > > Sachin. > > > > -----Original Message----- > > From: Felix Polyudov <fel...@ami.com> > > Sent: Tuesday, April 23, 2024 10:58 PM > > To: gaoliming <gaolim...@byosoft.com.cn>; Sachin Ganesh > > <sachingan...@ami.com>; devel@edk2.groups.io > > Cc: zhiguang....@intel.com; michael.d.kin...@intel.com; > > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen....@intel.com; > > erdemak...@google.com; min.m...@intel.com; > thomas.lenda...@amd.com; > > Dhanaraj V <vdhana...@ami.com> > > Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on > UEFI > > 2.10 and PI 1.8 Specification > > > > I think patch 6 can be updated to introduce unified PI specification > versioning > > macros without incrementing the minor revision, by changing > > PI_SPECIFICATION_MINOR_REVISION back to 70. > > This will ensure compliance with the versioning schema introduced in PI > 1.7B > > without changing the PI support level. > > (the macros were introduced by PIWG mantis 2101) > > > > -----Original Message----- > > From: gaoliming <gaolim...@byosoft.com.cn> > > Sent: Tuesday, April 23, 2024 10:49 AM > > To: Sachin Ganesh <sachingan...@ami.com>; devel@edk2.groups.io > > Cc: zhiguang....@intel.com; michael.d.kin...@intel.com; > > ardb+tianoc...@kernel.org; kra...@redhat.com; jiewen....@intel.com; > > erdemak...@google.com; min.m...@intel.com; > thomas.lenda...@amd.com; > > Felix Polyudov <fel...@ami.com>; Dhanaraj V <vdhana...@ami.com> > > Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI > 2.10 > > and PI 1.8 Specification > > > > > > **CAUTION: The e-mail below is from an external source. Please exercise > > caution before opening attachments, clicking links, or following guidance.** > > > > Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao > > <gaolim...@byosoft.com.cn> > > > > I suggest to merge others first. The patch 6/7 to update PI version from 1.7 > to > > 1.8 can be discussed first. > > > > Thanks > > Liming > > > -----邮件原件----- > > > 发件人: Sachin Ganesh <sachingan...@ami.com> > > > 发送时间: 2024年4月20日 5:46 > > > 收件人: devel@edk2.groups.io > > > 抄送: gaolim...@byosoft.com.cn; zhiguang....@intel.com; > > > michael.d.kin...@intel.com; ardb+tianoc...@kernel.org; > > > kra...@redhat.com; jiewen....@intel.com; erdemak...@google.com; > > > min.m...@intel.com; thomas.lenda...@amd.com; Felix Polyudov > > > <fel...@ami.com>; Dhanaraj V <vdhana...@ami.com>; Sachin Ganesh > > > <sachingan...@ami.com> > > > 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 > > > Specification > > > > > > This series of patches are for general updates to MdePkg and > > > MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications > > > > > > Sachin Ganesh (7): > > > MdePkg: Add definition for NVMe Over Fabric Device Path > > > MdePkg: Add new Resource Attributes defined in PI 1.8 Spec > > > MdePkg: Define Unaccepted Memory Type > > > MdeModulePkg: Use newly defined Unaccepted Memory Type > > > MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec > > > MdePkg: Update to PI 1.8 Revision > > > OvmfPkg: Use newly defined Unaccepted Memory Type > > > > > > MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 10 +++--- > > > MdeModulePkg/Core/Dxe/Mem/Page.c | 38 > > > ++++++++++---------- > > > MdeModulePkg/Include/Pi/PrePiDxeCis.h | 25 ------------- > > > MdeModulePkg/Include/Pi/PrePiHob.h | 20 ----------- > > > MdePkg/Include/Pi/PiDxeCis.h | 19 +++++----- > > > MdePkg/Include/Pi/PiHob.h | 14 +++----- > > > MdePkg/Include/Pi/PiMmCis.h | 6 ++-- > > > MdePkg/Include/Pi/PiMultiPhase.h | 6 ++++ > > > MdePkg/Include/Pi/PiPeiCis.h | 6 ++-- > > > MdePkg/Include/Pi/PiSmmCis.h | 2 +- > > > MdePkg/Include/Ppi/DelayedDispatch.h | 24 ++++++++++++- > > > MdePkg/Include/Protocol/DevicePath.h | 22 ++++++++++++ > > > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 4 +-- > > > OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 8 ++--- > > > OvmfPkg/Library/PeilessStartupLib/Hob.c | 4 +-- > > > OvmfPkg/Library/PlatformInitLib/IntelTdx.c | 8 ++--- > > > OvmfPkg/PlatformPei/AmdSev.c | 4 +-- > > > 17 files changed, 108 insertions(+), 112 deletions(-) delete mode > > > 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h > > > delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h > > > > > > -- > > > 2.24.1.windows.2 > > > -The information contained in this message may be confidential and > > > proprietary to American Megatrends (AMI). This communication is > > > intended > > to > > > be read only by the individual or entity to whom it is addressed or by > > their > > > designee. If the reader of this message is not the intended recipient, > > > you > > are > > > on notice that any distribution of this message, in any form, is > > > strictly prohibited. Please promptly notify the sender by reply e-mail > > > or by > > telephone > > > at 770-246-8600, and then delete or destroy all copies of the > > transmission= > > > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > to > > be read only by the individual or entity to whom it is addressed or by their > > designee. If the reader of this message is not the intended recipient, you > > are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > telephone > > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended to > be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118580): https://edk2.groups.io/g/devel/message/118580 Mute This Topic: https://groups.io/mt/105933432/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
