I think it is confusing to add "TCG_Sp800_155_PlatformId_Event3" field for
"TCG_Sp800_155_PlatformId_Event2" structure.
Maybe just create a new "TCG_Sp800_155_PlatformId_Event3" structure?
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dionna Glaze
> via groups.io
> Sent: Wednesday, May 1, 2024 8:53 AM
> To: devel@edk2.groups.io
> Cc: Dionna Glaze <dionnagl...@google.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Liu,
> Zhiguang <zhiguang....@intel.com>
> Subject: [edk2-devel] [PATCH 1/3] MdePkg: Add TcgSp800155Event3 type info
>
> TCG PC Client Platform Firmware Profile 1.06 revision 52 of December
> 2023 added a new event signature and extended information about where a
> reference measurement document for the firmware can be found.
>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang....@intel.com>
>
> Signed-off-by: Dionna Glaze <dionnagl...@google.com>
> ---
> MdePkg/Include/IndustryStandard/UefiTcgPlatform.h | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> index 61bd4e4667..30df8302b1 100644
> --- a/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> +++ b/MdePkg/Include/IndustryStandard/UefiTcgPlatform.h
> @@ -451,6 +451,7 @@ typedef struct tdTCG_PCClientTaggedEvent {
>
> #define TCG_Sp800_155_PlatformId_Event_SIGNATURE "SP800-155 Event"
> #define TCG_Sp800_155_PlatformId_Event2_SIGNATURE "SP800-155 Event2"
> +#define TCG_Sp800_155_PlatformId_Event3_SIGNATURE "SP800-155 Event3"
>
> typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
> UINT8 Signature[16];
> @@ -478,7 +479,16 @@ typedef struct tdTCG_Sp800_155_PlatformId_Event2 {
> // UINT8
> FirmwareManufacturerStr[FirmwareManufacturerStrSize];
> // UINT32 FirmwareManufacturerId;
> // UINT8 FirmwareVersion;
> - // UINT8 FirmwareVersion[FirmwareVersionSize]];
> + // UINT8 FirmwareVersion[FirmwareVersionSize];
> + //
> + // Below structure is newly added in TCG_Sp800_155_PlatformId_Event3
> + //
> + // UINT32 RimLocatorType;
> + // UINT32 RimLocatorLength;
> + // UINT8 RimLocator[RimLocatorLength];
> + // UINT32 PlatformCertLocatorType;
> + // UINT32 PlatformCertLocatorLength;
> + // UINT8 PlatformCertLocator[PlatformCertLocatorLength];
> } TCG_Sp800_155_PlatformId_Event2;
>
> #define TCG_EfiStartupLocalityEvent_SIGNATURE "StartupLocality"
> --
> 2.45.0.rc0.197.gbae5840b3b-goog
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118453): https://edk2.groups.io/g/devel/message/118453
Mute This Topic: https://groups.io/mt/105833238/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
