Thanks Ray, please help add the push label for the PR: https://github.com/tianocore/edk2/pull/5610
From: Ni, Ray <[email protected]> Sent: Tuesday, April 30, 2024 1:33 PM To: Wu, Jiaxin <[email protected]>; [email protected] Cc: Zeng, Star <[email protected]>; Gerd Hoffmann <[email protected]>; Kumar, Rahul R <[email protected]> Subject: Re: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport Reviewed-by: Ray Ni <[email protected]<mailto:[email protected]>> Thanks, Ray ________________________________ From: Wu, Jiaxin <[email protected]<mailto:[email protected]>> Sent: Monday, April 29, 2024 13:31 To: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> Cc: Ni, Ray <[email protected]<mailto:[email protected]>>; Zeng, Star <[email protected]<mailto:[email protected]>>; Gerd Hoffmann <[email protected]<mailto:[email protected]>>; Kumar, Rahul R <[email protected]<mailto:[email protected]>> Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport ProcessorNumber 0 is not always BSP. Debug message based on 0 of ProcessorNumber is incorrect. This patch is to clean the debug message in LmceSupport directly. Cc: Ray Ni <[email protected]<mailto:[email protected]>> Cc: Zeng Star <[email protected]<mailto:[email protected]>> Cc: Gerd Hoffmann <[email protected]<mailto:[email protected]>> Cc: Rahul Kumar <[email protected]<mailto:[email protected]>> Signed-off-by: Jiaxin Wu <[email protected]<mailto:[email protected]>> --- UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c index d8b070d9f1..cb569769a1 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c @@ -1,9 +1,9 @@ /** @file Machine Check features. - Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.<BR> SPDX-License-Identifier: BSD-2-Clause-Patent **/ #include "CpuCommonFeatures.h" @@ -287,13 +287,10 @@ LmceSupport ( if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) { return FALSE; } McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP); - if (ProcessorNumber == 0) { - DEBUG ((DEBUG_INFO, "LMCE enable = %x\n", (BOOLEAN)(McgCap.Bits.MCG_LMCE_P != 0))); - } return (BOOLEAN)(McgCap.Bits.MCG_LMCE_P != 0); } /** -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118410): https://edk2.groups.io/g/devel/message/118410 Mute This Topic: https://groups.io/mt/105795776/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
