Sam: I would suggest to separate this patch 3/4 to two patches. One is to add UEFI definition, another is to add EBBR definition. Do you think so?
Thanks Liming > -----邮件原件----- > 发件人: Sam Kaynor <sam.kay...@arm.com> > 发送时间: 2024年4月29日 21:49 > 收件人: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > 抄送: 'Michael D Kinney' <michael.d.kin...@intel.com>; 'Zhiguang Liu' > <zhiguang....@intel.com> > 主题: RE: [PATCH v6 3/4] MdePkg: Adding support for > EFI_CONFORMANCE_PROFILE_TABLE > > Liming, > > Excuse me, I forgot to include the spec for that GUID. It's defined in the > Embedded Base Boot Requirements (EBBR) specification 2.1.0 release. > https://arm-software.github.io/ebbr/ > > Thanks, > Sam > > -----Original Message----- > From: gaoliming <gaolim...@byosoft.com.cn> > Sent: Sunday, April 28, 2024 8:05 PM > To: Sam Kaynor <sam.kay...@arm.com>; devel@edk2.groups.io > Cc: 'Michael D Kinney' <michael.d.kin...@intel.com>; 'Zhiguang Liu' > <zhiguang....@intel.com> > Subject: 回复: [PATCH v6 3/4] MdePkg: Adding support for > EFI_CONFORMANCE_PROFILE_TABLE > > Sam: > I don't find EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID definition in > UEFI 2.10 spec. So, what's its definition from? > > Thanks > Liming > > -----邮件原件----- > > 发件人: Sam Kaynor <sam.kay...@arm.com> > > 发送时间: 2024年4月27日 1:53 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao > > <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com> > > 主题: [PATCH v6 3/4] MdePkg: Adding support for > > EFI_CONFORMANCE_PROFILE_TABLE > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 > > > > Adding support for EFI_CONFORMANCE_PROFILE_TABLE by adding an > > associated header file and relevant GUIDs to MdePkg.dec as defined in > > the UEFI 2.10 spec. > > This table is needed to address changes being made within ShellPkg. > > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Signed-off-by: Sam Kaynor <sam.kay...@arm.com> > > --- > > > > Notes: > > v6: > > - Added patch to address MdePkg changes separately > > > > MdePkg/MdePkg.dec | 5 ++ > > MdePkg/Include/Guid/ConformanceProfiles.h | 56 > ++++++++++++++++++++ > > 2 files changed, 61 insertions(+) > > > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index > > bf94549cbfbd..2c053a7459f3 100644 > > --- a/MdePkg/MdePkg.dec > > +++ b/MdePkg/MdePkg.dec > > @@ -746,6 +746,11 @@ [Guids] > > ## Include/Guid/DeviceAuthentication.h > > gEfiDeviceSignatureDatabaseGuid = { 0xb9c2b4f4, 0xbf5f, 0x462d, > > {0x8a, 0xdf, 0xc5, 0xc7, 0xa, 0xc3, 0x5d, 0xad }} > > > > + ## Include/Guid/ConformanceProfiles.h > > + gEfiConfProfilesTableGuid = { 0x36122546, 0xf7e7, 0x4c8f, { > 0xbd, > > 0x9b, 0xeb, 0x85, 0x25, 0xb5, 0x0c, 0x0b }} > > + gEfiConfProfilesUefiSpecGuid = { 0x523c91af, 0xa195, 0x4382, { > 0x81, > > 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }} > > + gEfiConfProfilesEbbrSpecGuid = { 0xcce33c35, 0x74ac, 0x4087, > > { 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }} > > + > > # > > # GUID defined in PI1.0 > > # > > diff --git a/MdePkg/Include/Guid/ConformanceProfiles.h > > b/MdePkg/Include/Guid/ConformanceProfiles.h > > new file mode 100644 > > index 000000000000..c6211d63d79c > > --- /dev/null > > +++ b/MdePkg/Include/Guid/ConformanceProfiles.h > > @@ -0,0 +1,56 @@ > > +/** @file > > + Legal information > > + > > +**/ > > + > > +#ifndef __CONFORMANCE_PROFILES_TABLE_GUID_H__ > > +#define __CONFORMANCE_PROFILES_TABLE_GUID_H__ > > + > > + > > +// > > +// This table allows the platform to advertise its UEFI specification > > conformance > > +// in the form of pre-defined profiles. Each profile is identified by > > +a > GUID, > > with > > +// known profiles listed in the section below. > > +// The absence of this table shall indicate that the platform > implementation > > is > > +// conformant with the UEFI specification requirements, as defined in > > Section 2.6. > > +// This is equivalent to publishing this configuration table with the > > +// EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID conformance profile. > > +// > > +#define EFI_CONFORMANCE_PROFILES_TABLE_GUID \ > > + { \ > > + 0x36122546, 0xf7e7, 0x4c8f, { 0xbd, 0x9b, 0xeb, 0x85, 0x25, 0xb5, > 0x0c, > > 0x0b } \ > > + } > > + > > +#pragma pack(1) > > + > > +typedef struct { > > + /// > > + /// Version of the table must be 0x1 > > + /// > > + UINT16 Version; > > + /// > > + /// The number of profiles GUIDs present in ConformanceProfiles > > + /// > > + UINT16 NumberOfProfiles; > > + /// > > + /// An array of conformance profile GUIDs that are supported by > > +this > > system. > > + /// EFI_GUID ConformanceProfiles[]; > > + /// > > +} EFI_CONFORMANCE_PROFILES_TABLE; > > + > > +#define EFI_CONFORMANCE_PROFILES_TABLE_VERSION 0x1 > > + > > +// > > +// GUID defined in spec. > > +// > > +#define EFI_CONFORMANCE_PROFILES_UEFI_SPEC_GUID \ > > + { 0x523c91af, 0xa195, 0x4382, \ > > + { 0x81, 0x8d, 0x29, 0x5f, 0xe4, 0x00, 0x64, 0x65 }} #define > > +EFI_CONFORMANCE_PROFILE_EBBR_2_1_GUID \ > > + { 0xcce33c35, 0x74ac, 0x4087, \ > > + { 0xbc, 0xe7, 0x8b, 0x29, 0xb0, 0x2e, 0xeb, 0x27 }} > > + > > +extern EFI_GUID gEfiConfProfilesTableGuid; extern EFI_GUID > > +gEfiConfProfilesUefiSpecGuid; > > + > > +#endif > > -- > > 2.34.1 > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, > please notify the sender immediately and do not disclose the contents to any > other person, use it for any purpose, or store or copy the information in any > medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118398): https://edk2.groups.io/g/devel/message/118398 Mute This Topic: https://groups.io/mt/105814144/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
