Reviewed-by: Ray Ni <[email protected]> Thanks, Ray ________________________________ From: Liu, Zhiguang <[email protected]> Sent: Thursday, April 25, 2024 12:40 To: [email protected] <[email protected]> Cc: Liu, Zhiguang <[email protected]>; Liming Gao <[email protected]>; Wu, Jiaxin <[email protected]>; Ni, Ray <[email protected]>; Laszlo Ersek <[email protected]>; Ard Biesheuvel <[email protected]>; Sami Mujawar <[email protected]> Subject: [PATCH 2/2] StandaloneMmPkg: Initialize 'WillReturn' variable
The local variable 'WillReturn' was being used without prior initialization in some code paths. This patch ensures that 'WillReturn' is properly initialized to prevent undefined behavior. Cc: Liming Gao <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ray Ni <[email protected]> Cc: Laszlo Ersek <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Sami Mujawar <[email protected]> Signed-off-by: Zhiguang Liu <[email protected]> --- StandaloneMmPkg/Core/Mmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c index e035245c87..fb205df490 100644 --- a/StandaloneMmPkg/Core/Mmi.c +++ b/StandaloneMmPkg/Core/Mmi.c @@ -174,6 +174,7 @@ MmiManage ( EFI_STATUS Status; mMmiManageCallingDepth++; + WillReturn = FALSE; Status = EFI_NOT_FOUND; ReturnStatus = Status; if (HandlerType == NULL) { -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118268): https://edk2.groups.io/g/devel/message/118268 Mute This Topic: https://groups.io/mt/105725160/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
