Ok, thanks Ray, I will follow the change in next version. From: Ni, Ray <ray...@intel.com> Sent: Thursday, April 18, 2024 4:15 PM To: Wu, Jiaxin <jiaxin...@intel.com>; devel@edk2.groups.io Cc: Zeng, Star <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; Kumar, Rahul R <rahul.r.ku...@intel.com> Subject: Re: [PATCH v3 13/13] UefiCpuPkg/PiSmmCpuDxeSmm: Remove SmBases relocation logic
+ // + // Check whether the Required TileSize is enough. + // + if (TileSize > SIZE_8KB) { + DEBUG ((DEBUG_ERROR, "The Range of Smbase in SMRAM is not enough -- Required TileSize = 0x%08x, Actual TileSize = 0x%08x\n", TileSize, SIZE_8KB)); + FreePool (mCpuHotPlugData.SmBase); + FreePool (gSmmCpuPrivate->ProcessorInfo); + CpuDeadLoop (); + return RETURN_BUFFER_TOO_SMALL; } [Ray] Can you move the "TileSize" check just below the original TileSize calculation logic? Others look good to me. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118002): https://edk2.groups.io/g/devel/message/118002 Mute This Topic: https://groups.io/mt/105593584/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-