Yes, because I moved the SmmRelocationLib within the condition of SMM_REQUIRE == TRUE in the version 2 patch. It should be always included since the PlatformPei need consume it.
I will fix it in the next version patch. It won't impact the code review & test with SMM_REQUIRE == TRUE build. Thanks, Jiaxin > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Tuesday, April 16, 2024 3:31 PM > To: devel@edk2.groups.io; Wu, Jiaxin <jiaxin...@intel.com> > Cc: Ni, Ray <ray...@intel.com>; Zeng, Star <star.z...@intel.com>; Kumar, > Rahul R <rahul.r.ku...@intel.com>; Dong, Guo <guo.d...@intel.com>; > Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; > Guo, Gua <gua....@intel.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com>; Abdul > Lateef Attar <abdullateef.at...@amd.com>; Abner Chang > <abner.ch...@amd.com>; Tom Lendacky <thomas.lenda...@amd.com> > Subject: Re: [edk2-devel] [PATCH v2 00/10] Add SmmRelocationLib > > On Mon, Apr 15, 2024 at 09:30:11PM +0800, Wu, Jiaxin wrote: > > Intel plans to separate the smbase relocation logic from > > PiSmmCpuDxeSmm driver, and the related behavior will be > > moved to the new interface defined by the SmmRelocationLib > > class. > > > > The SmmRelocationLib class provides the SmmRelocationInit() > > interface for platform to do the smbase relocation, which > > shall provide below 2 functionalities: > > 1. Relocate smbases for each processor. > > 2. Create the gSmmBaseHobGuid HOB. > > > > With SmmRelocationLib, PiSmmCpuDxeSmm driver (which runs at > > a later phase) can be simplfied as below for SMM init: > > 1. Consume the gSmmBaseHobGuid HOB for the relocated smbases > > for each Processor. > > 2. Execute the early SMM Init. > > How this was tested? > I can't even build this (without -D SMM_REQUIRE=TRUE). > > /home/kraxel/projects/edk2/OvmfPkg/OvmfPkgX64.dsc(...): error 4000: > Instance of library class [SmmRelocationLib] is not found > in > [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] [X64] > consumed by module > [/home/kraxel/projects/edk2/OvmfPkg/PlatformPei/PlatformPei.inf] > > I doubt it passes CI. > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117873): https://edk2.groups.io/g/devel/message/117873 Mute This Topic: https://groups.io/mt/105535804/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
