The function looks good to me. But still have some coding style issue: "Always put space before an open parenthesis" And for patch #2, the comment of GetBaseName is incorrect. With the coding style issue fix and comments correction, Reviewed-by: Zhichao Gao <[email protected]>
Thanks, Zhichao > -----Original Message----- > From: Sam Kaynor <[email protected]> > Sent: Thursday, April 4, 2024 5:20 AM > To: [email protected] > Cc: Ni, Ray <[email protected]>; Gao, Zhichao <[email protected]>; > Kinney, Michael D <[email protected]>; Liming Gao > <[email protected]>; Liu, Zhiguang <[email protected]>; > Stuart Yoder <[email protected]> > Subject: [PATCH v4 0/3] Adding support for verbose UEFI Table dumping to > Dmem.c > > This adds an additional option to the dmem UEFI shell command for verbose > dumping of a couple of UEFI tables. > > The tables specified are the RT Properties Table, the Image Execution Table, > and the Conformance Profiles table. > > Supporting objects are added in the .inf and .uni files relating to Dmem.c and > an additional header file for the Conformance Profiles table was added. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352 > > v3->v4: > - Resolved crash when RT Properties table isn't present > - Added output to help command to include -verbose option > - Changed Image Exe Table output to more closely match spec > > Cc: Ray Ni <[email protected]> > Cc: Zhichao Gao <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Zhiguang Liu <[email protected]> > Cc: Stuart Yoder <[email protected]> > Signed-off-by: Sam Kaynor <[email protected]> > > Sam Kaynor (3): > ShellPkg: UefiShellDebug1CommandsLib: Dumping RT Properties in Dmem.c > ShellPkg: UefiShellDebug1CommandsLib: Image Execution Table in Dmem.c > ShellPkg: UefiShellDebug1CommandsLib: Conformance Profiles in Dmem.c > > MdePkg/MdePkg.dec | > 5 + > > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.inf | 3 + > MdePkg/Include/Guid/ConformanceProfiles.h | > 56 +++++ > ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | > 266 > ++++++++++++++++++++ > > ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Commands > Lib.uni | 31 ++- > 5 files changed, 359 insertions(+), 2 deletions(-) create mode 100644 > MdePkg/Include/Guid/ConformanceProfiles.h > > -- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117543): https://edk2.groups.io/g/devel/message/117543 Mute This Topic: https://groups.io/mt/105318207/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
