Appreciate your efforts in optimization of unit test, for this patch set:
Looks good to me.
Reviewed-by: Yi Li <yi1...@intel.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chris Ruffin via
groups.io
Sent: Sunday, March 31, 2024 6:00 AM
To: devel@edk2.groups.io
Cc: Chris Ruffin <v-chruf...@microsoft.com>
Subject: [edk2-devel] [PATCH v2 0/3] CryptoPkg/BaseCryptLib: add additional
RSAES-OAEP crypto functions
From: Chris Ruffin <v-chruf...@microsoft.com>
v2 patchset adds:
- Add digest length parameter to RsaOaepEncrypt(), RsaOaepDecrypt() so that
SHA256, SHA384, SHA512 message digests and mask generation functions can be
used with the API.
- Add NullLib implementation for BaseCryptLibMbedTls
- Cleanups from v1 review
- Significantly refactored and expanded test suite:
- Use UNIT_TEST_CONTEXT and abstaction to run same tests on
Pkcs1v2Encrypt()/Pkcs1v2Decrypt() and RsaOaepEncrypt() RsaOaepDecrypt()
- Align DER Certificate / PrivateKey used with Pkcs1v2 APIs
with RsaN, RsaE, RsaD parameters used by RsaOaep APIs
so that they represent the same keys.
- Implement fixed ciphertext test for Pkcs1v2Decrypt(), RsaOaepDecrypt()
- Implementation was also checked with wycheproof test vectors (not
included in the patch).
Chris Ruffin (3):
CryptoPkg/BaseCryptLib: add additional RSAES-OAEP crypto functions
CryptoPkg/Driver: add additional RSAES-OAEP crypto functions
CryptoPkg/BaseCryptLibUnitTest: add unit test functions
CryptoPkg/Driver/Crypto.c | 130 ++-
CryptoPkg/Include/Library/BaseCryptLib.h | 117 +++
.../Pcd/PcdCryptoServiceFamilyEnable.h | 4 +
.../Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c | 598 ++++++++++++--
.../BaseCryptLib/Pk/CryptPkcs1OaepNull.c | 130 ++-
.../Pk/CryptPkcs1OaepNull.c | 135 +++-
.../BaseCryptLibNull/Pk/CryptPkcs1OaepNull.c | 130 ++-
.../BaseCryptLibOnProtocolPpi/CryptLib.c | 114 +++
CryptoPkg/Private/Protocol/Crypto.h | 109 ++-
.../Library/BaseCryptLib/OaepEncryptTests.c | 758 ++++++++++++++++--
10 files changed, 2098 insertions(+), 127 deletions(-)
--
2.44.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117272): https://edk2.groups.io/g/devel/message/117272
Mute This Topic: https://groups.io/mt/105239222/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
