On Wed, Feb 28, 2024 at 09:51:41AM -0600, Tom Lendacky wrote: > On 2/28/24 02:40, Gerd Hoffmann wrote: > > > +/** > > > + Perform a native PVALIDATE operation for the page ranges specified. > > > + > > > + Validate or rescind the validation of the specified pages. > > > + > > > + @param[in] Info Pointer to a page state change > > > structure > > > + > > > +**/ > > > +STATIC > > > +VOID > > > +BasePvalidate ( > > > + IN SNP_PAGE_STATE_CHANGE_INFO *Info > > > + ) > > > > This is not mentioned in the commit message. > > > > Looks like you are moving or copying code from BaseMemEncryptSevLib. > > > > Moving code is best done with a patch doing the move only, without other > > functional changes. If that can't be done easily this should explained > > in the commit message. > > I can leave this as unsupported in this patch and then when switching over > to using the functions in patch #16, move the code at that time. > > For the VMSA update, that isn't as easy because of the interaction between > UefiCpuPkg (MpInitLib) and OvmfPkg and requires two separate patches, which > would cause bisection breakage.
Oh, right, cross-package code move isn't going to work. > Or I could keep this all here and expand the commit message to indicate that > the base support is being implemented based off of the existing support. I think adding clear annotations to the commit messages is fine then. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116229): https://edk2.groups.io/g/devel/message/116229 Mute This Topic: https://groups.io/mt/104512963/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
