Reviewed-by: Ray Ni <[email protected]> Thanks, Ray > -----Original Message----- > From: Laszlo Ersek <[email protected]> > Sent: Wednesday, February 28, 2024 4:47 PM > To: [email protected]; Liu, Zhiguang <[email protected]> > Cc: Liming Gao <[email protected]>; Wu, Jiaxin > <[email protected]>; Ni, Ray <[email protected]>; Ard Biesheuvel > <[email protected]>; Sami Mujawar <[email protected]> > Subject: Re: [edk2-devel] [PATCH v2 3/4] StandaloneMmPkg: Support to > unregister MMI handler inside MMI handler > > On 2/28/24 03:27, Zhiguang Liu wrote: > > To support unregister MMI handler inside MMI handler itself, > > get next node before MMI handler is executed, since LIST_ENTRY that > > Link points to may be freed if unregister MMI handler in MMI handler > > itself. > > > > Cc: Liming Gao <[email protected]> > > Cc: Jiaxin Wu <[email protected]> > > Cc: Ray Ni <[email protected]> > > Cc: Laszlo Ersek <[email protected]> > > Cc: Ard Biesheuvel <[email protected]> > > Cc: Sami Mujawar <[email protected]> > > Signed-off-by: Zhiguang Liu <[email protected]> > > --- > > StandaloneMmPkg/Core/Mmi.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/StandaloneMmPkg/Core/Mmi.c > b/StandaloneMmPkg/Core/Mmi.c > > index 0de6fd17fc..c1a1d76e85 100644 > > --- a/StandaloneMmPkg/Core/Mmi.c > > +++ b/StandaloneMmPkg/Core/Mmi.c > > @@ -154,9 +154,14 @@ MmiManage ( > > Head = &MmiEntry->MmiHandlers; > > } > > > > - for (Link = Head->ForwardLink; Link != Head; Link = Link->ForwardLink) { > > + for (Link = Head->ForwardLink; Link != Head;) { > > MmiHandler = CR (Link, MMI_HANDLER, Link, > MMI_HANDLER_SIGNATURE); > > - > > + // > > + // To support unregister MMI handler inside MMI handler itself, > > + // get next node before handler is executed, since LIST_ENTRY that > > + // Link points to may be freed if unregister MMI handler. > > + // > > + Link = Link->ForwardLink; > > Status = MmiHandler->Handler ( > > (EFI_HANDLE)MmiHandler, > > Context, > > Reviewed-by: Laszlo Ersek <[email protected]>
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116163): https://edk2.groups.io/g/devel/message/116163 Mute This Topic: https://groups.io/mt/104616994/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
