This change is good to me. Reviewed-by: Liming Gao
<gaolim...@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael
> Kubacki
> 发送时间: 2024年2月20日 23:22
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao <gaolim...@byosoft.com.cn>; Ray Ni <ray...@intel.com>;
> Rebecca Cran <rebe...@bsdio.com>; Richard Ho <richar...@ami.com>
> 主题: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/Bus/Usb/UsbNetwork:
> Check array index range before access
>
> From: Michael Kubacki <michael.kuba...@microsoft.com>
>
> Checks that an offset used to access array elements is within the
> expected range before accessing the array item.
>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Ray Ni <ray...@intel.com>
> Cc: Rebecca Cran <rebe...@bsdio.com>
> Cc: Richard Ho <richar...@ami.com>
> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
> ---
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c |
> 2 +-
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbNcmFunction.c |
> 2 +-
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndisFunction.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
> b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
> index 29f4508a38ce..0c1f252b85df 100644
> --- a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
> +++ b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbEcmFunction.c
> @@ -769,7 +769,7 @@ ConvertFilter (
>
> Count = sizeof (gTable)/sizeof (gTable[0]);
>
> - for (Index = 0; (gTable[Index].Src != 0) && (Index < Count); Index++) {
> + for (Index = 0; (Index < Count) && (gTable[Index].Src != 0); Index++) {
> if (gTable[Index].Src & Value) {
> *CdcFilter |= gTable[Index].Dst;
> }
> diff --git
> a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbNcmFunction.c
> b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbNcmFunction.c
> index baa2225bf8a8..ef01a6f5458c 100644
> --- a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbNcmFunction.c
> +++
> b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbNcmFunction.c
> @@ -855,7 +855,7 @@ ConvertFilter (
>
> Count = sizeof (gTable)/sizeof (gTable[0]);
>
> - for (Index = 0; (gTable[Index].Src != 0) && (Index < Count); Index++) {
> + for (Index = 0; (Index < Count) && (gTable[Index].Src != 0); Index++) {
> if (gTable[Index].Src & Value) {
> *CdcFilter |= gTable[Index].Dst;
> }
> diff --git
> a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndisFunction.c
> b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndisFunction.c
> index 2c0dcae4cf96..6d45a1b775ba 100644
> --- a/MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndisFunction.c
> +++ b/MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndisFunction.c
> @@ -803,7 +803,7 @@ ConvertFilter (
>
> Count = sizeof (gTable)/sizeof (gTable[0]);
>
> - for (Index = 0; (gTable[Index].Src != 0) && (Index < Count); Index++) {
> + for (Index = 0; (Index < Count) && (gTable[Index].Src != 0); Index++) {
> if (gTable[Index].Src & Value) {
> *CdcFilter |= gTable[Index].Dst;
> }
> --
> 2.40.1.vfs.0.0
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#115654):
> https://edk2.groups.io/g/devel/message/115654
> Mute This Topic: https://groups.io/mt/104469090/4905953
> Group Owner: devel+ow...@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub
> [gaolim...@byosoft.com.cn]
> -=-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115977): https://edk2.groups.io/g/devel/message/115977
Mute This Topic: https://groups.io/mt/104586147/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
