On 1/24/24 17:38, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
> ---
> OvmfPkg/Microvm/MicrovmX64.dsc | 55 ++++++++--------------------------
> OvmfPkg/Microvm/MicrovmX64.fdf | 9 ++----
> 2 files changed, 14 insertions(+), 50 deletions(-)
>
> diff --git a/OvmfPkg/Microvm/MicrovmX64.dsc b/OvmfPkg/Microvm/MicrovmX64.dsc
> index 063324cd0572..2f2b95c9f0fa 100644
> --- a/OvmfPkg/Microvm/MicrovmX64.dsc
> +++ b/OvmfPkg/Microvm/MicrovmX64.dsc
> @@ -33,6 +33,11 @@ [Defines]
> DEFINE SMM_REQUIRE = FALSE
> DEFINE SOURCE_DEBUG_ENABLE = FALSE
>
> + #
> + # Shell can be useful for debugging but should not be enabled for
> production
> + #
> + DEFINE BUILD_SHELL = TRUE
> +
> #
> # Network definition
> #
> @@ -230,8 +235,6 @@ [LibraryClasses]
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> !endif
>
> - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> - ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>
> S3BootScriptLib|MdeModulePkg/Library/PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf
> SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf
>
> OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeLib/BaseOrderedCollectionRedBlackTreeLib.inf
> @@ -239,6 +242,8 @@ [LibraryClasses]
>
> Tcg2PhysicalPresenceLib|OvmfPkg/Library/Tcg2PhysicalPresenceLibNull/DxeTcg2PhysicalPresenceLib.inf
>
> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
> +!include OvmfPkg/Include/Dsc/ShellLibs.dsc.inc
> +
> [LibraryClasses.common]
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> CcExitLib|OvmfPkg/Library/CcExitLib/CcExitLib.inf
> @@ -837,50 +842,14 @@ [Components]
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
>
> -!if $(TOOL_CHAIN_TAG) != "XCODE5"
> - ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf {
> - <PcdsFixedAtBuild>
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - }
> - ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf {
> - <PcdsFixedAtBuild>
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - }
> -
> ShellPkg/DynamicCommand/VariablePolicyDynamicCommand/VariablePolicyDynamicCommand.inf
> {
> - <PcdsFixedAtBuild>
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - }
> - OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf {
> - <PcdsFixedAtBuild>
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - }
> -!endif
> - ShellPkg/Application/Shell/Shell.inf {
> - <LibraryClasses>
> -
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> -
> NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> -!if $(NETWORK_IP6_ENABLE) == TRUE
> -
> NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> -!endif
> -
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf
> - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> -
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCommandLib.inf
> -
> - <PcdsFixedAtBuild>
> - gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|8000
> - }
> +!include OvmfPkg/Include/Dsc/ShellComponents.dsc.inc
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
>
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfigDxe.inf
> - OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf
> + OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf {
> + <LibraryClasses>
> + ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
> + }
> !endif
>
> OvmfPkg/PlatformDxe/Platform.inf
"OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf" should be left alone.
Acked-by: Laszlo Ersek <ler...@redhat.com>
> diff --git a/OvmfPkg/Microvm/MicrovmX64.fdf b/OvmfPkg/Microvm/MicrovmX64.fdf
> index c877b3f088f9..825bf9f5e41f 100644
> --- a/OvmfPkg/Microvm/MicrovmX64.fdf
> +++ b/OvmfPkg/Microvm/MicrovmX64.fdf
> @@ -257,13 +257,6 @@ [FV.DXEFV]
> INF EmbeddedPkg/Drivers/FdtClientDxe/FdtClientDxe.inf
> INF OvmfPkg/Fdt/VirtioFdtDxe/VirtioFdtDxe.inf
>
> -!if $(TOOL_CHAIN_TAG) != "XCODE5"
> -INF ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> -INF ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand.inf
> -INF
> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf
> -!endif
> -INF ShellPkg/Application/Shell/Shell.inf
> -
> INF MdeModulePkg/Logo/LogoDxe.inf
>
> #
> @@ -302,6 +295,8 @@ [FV.DXEFV]
> INF MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf
> INF MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf
>
> +!include OvmfPkg/Include/Fdf/ShellDxe.fdf.inc
> +
>
> ################################################################################
>
> [FV.FVMAIN_COMPACT]
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114436): https://edk2.groups.io/g/devel/message/114436
Mute This Topic: https://groups.io/mt/103935354/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
