On 1/25/24 04:20, Ni, Ray via groups.io wrote:
Acked-by: Ray Ni <ray...@intel.com>
+ Tom
Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC?
Not asking for this patch series, but there is a lot of duplicated code
between the two APIC libraries. It would be nice if there was a way to
have a common file where just a single copy of the duplicated code could live.
Acked-by: Tom Lendacky <thomas.lenda...@amd.com>
Thanks,
Tom
Thanks,
Ray
-----Original Message-----
From: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>
Sent: Thursday, January 25, 2024 1:02 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liming Gao
<gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>; Ni,
Ray <ray...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Gerd
Hoffmann <kra...@redhat.com>
Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended
topology
Gentle reminder, please review the patch series.
On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote:
Caution: This message originated from an External Source. Use proper
caution when opening attachments, clicking links, or responding.
From: Abdul Lateef Attar <abdullateef.at...@amd.com>
Resending the patch with updated Cc list.
PR: https://github.com/tianocore/edk2/pull/5269
V2: delta changes
- Added additional check apart from supported CPUID extneded number.
- removed EFIAPI
Implements AMD extended toplogy.
Adds CPUID macro
update APIC library to use new exteded cpuid.
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang....@intel.com>
Cc: Ray Ni <ray...@intel.com>
Cc: Rahul Kumar <rahul1.ku...@intel.com>
Cc: Gerd Hoffmann <kra...@redhat.com>
Cc: Abdul Lateef Attar <abdullateef.at...@amd.com>
Abdul Lateef Attar (2):
MdePkg: Adds AMD Extended CPU topology CPUID
UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu
topology
MdePkg/Include/Register/Amd/Cpuid.h | 23 +++-
.../Library/BaseXApicLib/BaseXApicLib.c | 126
+++++++++++++++++-
.../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126
+++++++++++++++++-
3 files changed, 272 insertions(+), 3 deletions(-)
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114430): https://edk2.groups.io/g/devel/message/114430
Mute This Topic: https://groups.io/mt/103802341/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
