On 1/24/24 15:35, Laszlo Ersek wrote: > I figure the most flexible approach for those that dislike email-based > review for embargoed patches would be if github.com supported locked > down *PRs* (i.e., not private organizatons). In other words, if those > PRs would be submitted against the same base repository and master > branch as every other PR, *but* they wouldn't be visible to anyone > except to a restricted group, and could never be merged. (For merging, > the approved version of the series would have to be posted publicly, > after the embargo.) > > ... Technically, the last paragraph could be implemented with current > github.com features: create a locked-down organization, fork edk2 under > that organization (without adding any non-upstream changes to the fork), > and submit the embargoed patch series as a PR against the fork. Never > merge the patch set into the fork (only use the fork for patch review).
Well, running the usual CI checks on the embargoed patch set, *inside the fork*, would be an extra problem... I don't know how github.com accounts for CI minutes in forks. Especially closed forks. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114307): https://edk2.groups.io/g/devel/message/114307 Mute This Topic: https://groups.io/mt/103913088/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
