Hi Mike,
Thanks for reviewing. Patch updated here:
https://edk2.groups.io/g/devel/message/114182.
From my check this change need not update with the same function header.
Can you help to review again?
Thanks
Ren, Suqiang
-----Original Message-----
From: Kinney, Michael D <michael.d.kin...@intel.com>
Sent: Tuesday, January 23, 2024 9:10 AM
To: Ren, SuqiangX <suqiangx....@intel.com>; devel@edk2.groups.io
Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Liu, Zhiguang
<zhiguang....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>
Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of
FileName on EFI_FILE_INFO
Hi Suqiang,
The comment line added look like is exceeds 80 columns. Please reformat.
Also, there are implementations of this service in the edk2 repo.
Please update those with this same function header update.
Thanks,
Mike
> -----Original Message-----
> From: Ren, SuqiangX <suqiangx....@intel.com>
> Sent: Thursday, January 11, 2024 1:04 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
> <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>
> Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition
> of FileName on EFI_FILE_INFO
>
> Hi All,
>
> Any comments about this patch?
>
> Thanks
> Ren, Suqiang
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ren,
> Suqiang
> Sent: Tuesday, December 26, 2023 1:22 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
> <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>
> Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of
> FileName on EFI_FILE_INFO
>
> Add the description of FileName to align with UEFI spec 2.10.
>
> REF: UEFI spec 2.10 Table 13.5.16
>
> Signed-off-by: Suqiang Ren <suqiangx....@intel.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang....@intel.com>
> ---
> MdePkg/Include/Guid/FileInfo.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdePkg/Include/Guid/FileInfo.h
> b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8
> 100644
> --- a/MdePkg/Include/Guid/FileInfo.h
> +++ b/MdePkg/Include/Guid/FileInfo.h
> @@ -46,7 +46,7 @@ typedef struct {
> ///
> UINT64 Attribute;
> ///
> - /// The Null-terminated name of the file.
> + /// The Null-terminated name of the file. For a root directory, the
> name is an empty string.
> ///
> CHAR16 FileName[1];
> } EFI_FILE_INFO;
> --
> 2.26.2.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114183): https://edk2.groups.io/g/devel/message/114183
Mute This Topic: https://groups.io/mt/103366883/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
