Mike: For the change of https://github.com/tianocore/edk2/pull/5170. We checked all the files for function XxxExtractConfig, find there is not function will return EFI_DEVICE_ERROR in the function code directly. One possible place is just call xxx ->BlockToConfig(), and the XxxExtractConfig will return the Status of call BlockToConfig(). For example in https://github.com/tianocore/edk2/blob/c251015292cc5f4ca003894e5922a40b08cd14b0/MdeModulePkg/Universal/DriverSampleDxe/DriverSample.c#L808 Status = HiiConfigRouting->BlockToConfig ( HiiConfigRouting, ConfigRequest, (UINT8 *)&PrivateData->Configuration, BufferSize, Results, Progress ); ...... return Status;
So need we change the code, if such BlockToConfig return failed, then ignore the detail reason, but return EFI_DEVICE_ERROR in function XxxExtractConfig? BR/Tan Ming. -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael D Kinney Sent: Saturday, January 20, 2024 10:32 AM To: Ren, SuqiangX <suqiangx....@intel.com>; gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io Cc: Liu, Zhiguang <zhiguang....@intel.com>; Li, Yi1 <yi1...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of HiiConfigAccess ExtractConfig Hi Suqiang, For the Browser/HII related changes to the MdePkg can you also prepare a patch to update the function headers in the implementation of these APIs and make sure the implementation conforms to the update header file changes? Thanks, Mike > -----Original Message----- > From: Ren, SuqiangX <suqiangx....@intel.com> > Sent: Sunday, January 14, 2024 6:09 PM > To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang > <zhiguang....@intel.com>; Li, Yi1 <yi1...@intel.com> > Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > HiiConfigAccess ExtractConfig > > Hi Liming, > > Could you help to merge below patches which all your reviewed-by? > Thanks! > https://github.com/tianocore/edk2/pull/5170 > https://github.com/tianocore/edk2/pull/5186 > https://github.com/tianocore/edk2/pull/5190 > > > Thanks > Ren, Suqiang > > -----Original Message----- > From: Ren, SuqiangX > Sent: Monday, January 8, 2024 9:31 PM > To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang > <zhiguang....@intel.com>; Li, Yi1 <yi1...@intel.com> > Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > HiiConfigAccess ExtractConfig > > Hi Liming, > > Could you please help to check and merge this patch? > https://github.com/tianocore/edk2/pull/5170 > > > Thanks > Ren, Suqiang > > -----Original Message----- > From: gaoliming <gaolim...@byosoft.com.cn> > Sent: Saturday, December 23, 2023 10:10 AM > To: devel@edk2.groups.io; Ren, SuqiangX <suqiangx....@intel.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang > <zhiguang....@intel.com>; Li, Yi1 <yi1...@intel.com> > Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > HiiConfigAccess ExtractConfig > > Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > > -----邮件原件----- > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 SuqiangX Ren > > 发送时间: 2023年12月21日 10:41 > > 收件人: devel@edk2.groups.io > > 抄送: Ren,Suqiang <suqiangx....@intel.com>; Michael D Kinney > > <michael.d.kin...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; > > Zhiguang Liu <zhiguang....@intel.com>; Yi Li <yi1...@intel.com> > > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of > > HiiConfigAccess ExtractConfig > > > > From: "Ren,Suqiang" <suqiangx....@intel.com> > > > > Add status code returned for HiiConfigAccess ExtractConfig to align > > with UEFI spec 2.10. > > > > REF: UEFI spec 2.10 Table 35.5.2 > > > > Signed-off-by: SuqiangX Ren <suqiangx....@intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Cc: Yi Li <yi1...@intel.com> > > --- > > MdePkg/Include/Protocol/HiiConfigAccess.h | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/Protocol/HiiConfigAccess.h > > b/MdePkg/Include/Protocol/HiiConfigAccess.h > > index 3baf91e07b2e..fbee7c52b021 100644 > > --- a/MdePkg/Include/Protocol/HiiConfigAccess.h > > +++ b/MdePkg/Include/Protocol/HiiConfigAccess.h > > @@ -102,9 +102,16 @@ typedef UINTN EFI_BROWSER_ACTION; > > string. > > > > @retval EFI_INVALID_PARAMETER Unknown name. Progress points > > - to the & before the name in > > + to the "&" before the name in > > question. > > > > + @retval EFI_INVALID_PARAMETER If Results or Progress is NULL. > > + > > + @retval EFI_ACCESS_DENIED The action violated a system > policy. > > + > > + @retval EFI_DEVICE_ERROR Failed to extract the current > > configuration > > + for one or more named elements. > > + > > **/ > > typedef > > EFI_STATUS > > -- > > 2.26.2.windows.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114128): https://edk2.groups.io/g/devel/message/114128 Mute This Topic: https://groups.io/mt/103596624/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
