hi Pedro, Thanks for the comments. I will describe more about how to fix it in the commit message. About the renaming, I hesitate about it, since there may be other usage about this param. However, I don't think it is a big concern. I will keep it as is for now.
Thanks Zhiguang > -----Original Message----- > From: Pedro Falcato <pedro.falc...@gmail.com> > Sent: Friday, January 19, 2024 12:19 AM > To: Liu, Zhiguang <zhiguang....@intel.com> > Cc: devel@edk2.groups.io; ler...@redhat.com; Ni, Ray <ray...@intel.com>; > Kumar, Rahul R <rahul.r.ku...@intel.com>; Gerd Hoffmann > <kra...@redhat.com>; Lee, Crystal <crystal...@ami.com.tw> > Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix issue that IsModified is > wrongly set in PageTableMap > > On Thu, Jan 18, 2024 at 2:21 AM Liu, Zhiguang <zhiguang....@intel.com> > wrote: > > > > Thanks Laszlo for the comment, I will send a new version of patch to fix > > this. > > > > Also include Pedro to see if Pedro have more comments. > > The patch's subject really doesn't describe the fix (describe what you did in > the > patch/commit, don't describe what you're fixing) > > I also liked your IsFlushTlbNeeded suggestion (it would help clarify what you > actually want to keep track of). > > > -- > Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114020): https://edk2.groups.io/g/devel/message/114020 Mute This Topic: https://groups.io/mt/103781942/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
