On 1/5/2024 4:12 AM, Sami Mujawar wrote:
- // if TimerPeriod is 0, this is a request to stop the watchdog.
+ // If we've exited Boot Services but TimerPeriod isn't zero, this
+ // indicates that the caller is doing something wrong.
+ if (mExitedBootServices && (TimerPeriod != 0)) {
[SAMI] Thanks for updating the code to return the error code.
However, I see you are not stopping the watchdog timer. Is this because you
expect the watchdog period to expire and reset the system?
I removed the code to stop the watchdog timer because it's an error
condition. However, I've updated it so it does also get stopped in this
case too.
Also, did you see an issue that motivated this patch, or this was just a case
of hardening the code?
Can you provide more information, please?
[/SAMI]
This was issues found and improvements made by various people in the
last couple of years that we're now upstreaming to contribute
improvements and reduce our diffs against upstream.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114018): https://edk2.groups.io/g/devel/message/114018
Mute This Topic: https://groups.io/mt/103538118/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
