Thanks Gerd for providing the inputs. I'll enhance the logic accordingly and submit the V2 patch.
Thanks AbduL On 16-01-2024 15:11, Gerd Hoffmann wrote:
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Tue, Jan 16, 2024 at 12:31:21PM +0530, Abdul Lateef Attar wrote:From: Abdul Lateef Attar <abdullateef.at...@amd.com> This patch adds support for AMD's new extended topology. If processor supports CPUID 80000026 leaf then obtain the topology information using new method. + /// Check if extended toplogy supported + AsmCpuid (CPUID_EXTENDED_FUNCTION, &MaxExtendedCpuIdIndex, NULL, NULL, NULL); + if (MaxExtendedCpuIdIndex < AMD_CPUID_EXTENDED_TOPOLOGY) { + GetProcessorLocationByApicId (InitialApicId, Package, Core, Thread); + return; + }Sure this is correct? On Intel processors checking MaxExtendedCpuIdIndex alone is not enough, see commit 170d4ce8e90a ("UefiCpuPkg/BaseXApicX2ApicLib: fix CPUID_V2_EXTENDED_TOPOLOGY detection") Especially in virtual machines it can happen that the vCPU supports extended cpuid leaf N but does not support N-1, so checking MaxExtendedCpuIdIndex alone looks rather fragile to me. take care, Gerd
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113897): https://edk2.groups.io/g/devel/message/113897 Mute This Topic: https://groups.io/mt/103757657/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
