Sounds good, thank you.
Reviewed-by: Yi Li <yi1...@intel.com>
-----Original Message-----
From: Hou, Wenxing <wenxing....@intel.com>
Sent: Monday, January 8, 2024 4:23 PM
To: Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen....@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>
Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls
Hi,
For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISION,
because the previous code only had GCC build failure. This MACRO doesn't affect
the VS build.
For GCC build, the previous code didn`t have the size because of the build
failure.
To compare the size ,I add the dummy API for previous code:
tu_int __udivti3 (tu_int a, tu_int b) { return 0;} And the size has very small
change(<1kb) for enable or disable MBEDTLS_NO_UDBL_DIVISION.
Thanks
Wenxing
-----Original Message-----
From: Li, Yi1 <yi1...@intel.com>
Sent: Thursday, January 4, 2024 4:59 PM
To: Hou, Wenxing <wenxing....@intel.com>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen....@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>
Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls
Hi,
> disabling it can reduce code size in some embedded targets.
Could you provide size change after/before this define enabled?
Thanks,
Yi
-----Original Message-----
From: Hou, Wenxing <wenxing....@intel.com>
Sent: Thursday, January 4, 2024 4:34 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen....@intel.com>; Li, Yi1 <yi1...@intel.com>; Jiang,
Guomin <guomin.ji...@intel.com>
Subject: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630
Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure.
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Yi Li <yi1...@intel.com>
Cc: Guomin Jiang <guomin.ji...@intel.com>
Signed-off-by: Wenxing Hou <wenxing....@intel.com>
---
CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h
b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h
index ae9ef3a1b380..3068612c0815 100644
--- a/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h
+++ b/CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h
@@ -67,7 +67,7 @@
* example, if double-width division is implemented in software, disabling
* it can reduce code size in some embedded targets.
*/
-// #define MBEDTLS_NO_UDBL_DIVISION
+#define MBEDTLS_NO_UDBL_DIVISION
/**
* \def MBEDTLS_NO_64BIT_MULTIPLICATION
--
2.26.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113371): https://edk2.groups.io/g/devel/message/113371
Mute This Topic: https://groups.io/mt/103519146/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
