[AMD Official Use Only - General] > -----Original Message----- > From: Chang, Abner > Sent: Sunday, January 7, 2024 8:19 PM > To: Michael Brown <mc...@ipxe.org>; devel@edk2.groups.io > Cc: Saloni Kasbekar <saloni.kasbe...@intel.com>; Zachary Clark-williams > <zachary.clark-willi...@intel.com>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: RE: [PATCH 3/5] NetwokrPkg/HttpDxe: Add HttpEventTlsConfigured > HTTP callback event > > > > -----Original Message----- > > From: Michael Brown <mc...@ipxe.org> > > Sent: Saturday, January 6, 2024 1:15 AM > > To: Chang, Abner <abner.ch...@amd.com>; devel@edk2.groups.io > > Cc: Saloni Kasbekar <saloni.kasbe...@intel.com>; Zachary Clark-williams > > <zachary.clark-willi...@intel.com>; Nickle Wang <nick...@nvidia.com>; > Igor > > Kulchytskyy <ig...@ami.com> > > Subject: Re: [PATCH 3/5] NetwokrPkg/HttpDxe: Add > HttpEventTlsConfigured > > HTTP callback event > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > On 05/01/2024 08:37, abner.ch...@amd.com wrote: > > > + /// > > > + /// The Status of Event to configure TLS configuration data. > > > + /// EventStatus: > > > + /// EFI_SUCCESS The TLS is configured successfully with the > > > default > > value. > > > + /// EFI_INVALID_PARAMETER One or more input parameters to > > SetSessionData() is invalid. > > > + /// EFI_NOT_READY Current TLS session state is NOT > > EfiTlsSessionStateNotStarted. > > > + /// EFI_NOT_FOUND Fail to get 'HttpTlsCipherList' variable. > > > + /// Others Other error as indicated. > > > + /// > > > + HttpEventTlsConfigured, > > > + > > > > Since this changes the ABI, you may want to also update the protocol > > GUID to prevent strange errors if old and new binaries are used on the > > same system. > This makes sense, will send out V2. Hi Michael, In order to minimize the change, I decided to relocate HttpEventTlsConfigured to the end of enum declaration to keep the enum number backward compatible.
Please check it in V2 patch. Thanks Abner > > Thanks > Abner > > > > > Reviewed-by: Michael Brown <mc...@ipxe.org> > > > > Thanks, > > > > Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113326): https://edk2.groups.io/g/devel/message/113326 Mute This Topic: https://groups.io/mt/103539580/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
