Hi Liming, I created a PR and CI passed, could you help merge it? https://github.com/tianocore/edk2/pull/5210
Thanks, Yi -----Original Message----- From: gaoliming <gaolim...@byosoft.com.cn> Sent: Wednesday, January 3, 2024 8:52 AM To: Xu, Wei6 <wei6...@intel.com>; Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com> Subject: 回复: [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> for this patch set. > -----邮件原件----- > 发件人: Xu, Wei6 <wei6...@intel.com> > 发送时间: 2024年1月2日 9:43 > 收件人: Li, Yi1 <yi1...@intel.com>; devel@edk2.groups.io > 抄送: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com> > 主题: RE: [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency > expression > > Reviewed-by: Wei6 Xu <wei6...@intel.com> > > -----Original Message----- > From: Li, Yi1 <yi1...@intel.com> > Sent: Wednesday, December 20, 2023 9:55 AM > To: devel@edk2.groups.io > Cc: Li, Yi1 <yi1...@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > Liu, Zhiguang <zhiguang....@intel.com>; Xu, Wei6 <wei6...@intel.com> > Subject: [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency > expression > > To avoid messy parsing of the Depex section of a Capsule, it would be > a lot > easier for everyone involved if we preceded the Capsule Depex Section > with a > length declaration. It provides simple bounds checking to avoid having > to parse the op-codes, but in the case of a malformed depex being > parsed, avoid > other issues which can be messy. > > Syntax > DECLARE_LENGTH <32-bit Length> > Description > Declares an 32-bit byte length of the entire dependency expression. > Behaviors and Restrictions > This opcode must be the first one in a dependency expression. > > REF: UEFI spec 2.10 Table 23.4 > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > Cc: Wei6 Xu <wei6...@intel.com> > > Yi Li (2): > MdePkg: Add DECLARE_LENGTH opcode of dependency expression > FmpDevicePkg: Add DECLARE_LENGTH opcode of dependency expression > > .../FmpDependencyLib/FmpDependencyLib.c | 35 ++++++++ > .../PrivateInclude/FmpLastAttemptStatus.h | 3 + > .../EvaluateDependencyUnitTest.c | 84 > ++++++++++++++++--- > MdePkg/Include/Protocol/FirmwareManagement.h | 29 +++---- > 4 files changed, 125 insertions(+), 26 deletions(-) > > -- > 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113067): https://edk2.groups.io/g/devel/message/113067 Mute This Topic: https://groups.io/mt/103499595/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
