[AMD Official Use Only - General] > -----Original Message----- > From: Michael Brown <mc...@ipxe.org> > Sent: Thursday, December 28, 2023 11:32 PM > To: devel@edk2.groups.io; Chang, Abner <abner.ch...@amd.com> > Cc: Saloni Kasbekar <saloni.kasbe...@intel.com>; Zachary Clark-williams > <zachary.clark-willi...@intel.com>; Nickle Wang <nick...@nvidia.com>; Igor > Kulchytskyy <ig...@ami.com> > Subject: Re: [edk2-devel] [RFC][PATCH 0/2] Introduce HTTPS Platform TLS > policy > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 28/12/2023 15:04, Chang, Abner via groups.io wrote: > >> With the TLS protocol installed onto the same handle, I don't think you > >> then even need to use RegisterProtocolNotify(). On return from > >> EFI_HTTP_PROTOCOL.Request() you can open the TLS protocol on the > handle > >> and immediately call SetSessionData() to override VerifyMethod etc. > >> > > This part I am not sure, as TLS is initiated on the first HttpRequest. > Reconfigure TLS session on return from HTTP Request function means we > have to take one time error. I think I will still use RegisterProtocolNotify > and > LocateHandle with ByRegisterNotify to get the newly installed TLS handle, then > check it with REST EX HTTP handle. Hook the TLS SetSessionData() function > provided by REST EX, override the value then invoke the original > SetSessionData(). Something like this. > > As far as I am aware, EfiHttpRequest sets up all of the relevant data > structures but functions as a non-blocking open. If you reconfigure the > TLS session immediately after return from EfiHttpRequest() then this > reconfiguration should take effect before any network packets have been > transmitted or received. I have not tested this, though. > > If the immediate reconfiguration does not work, then your suggestion of > hooking SetSessionData() sounds like the easiest approach. I think the non-blocking transfer still sends out the request but just not waiting the response there, have to check the implementation.
> > > Would you like to refactor HttpSupport.c or let me do that? > > Nobody is paying me to work on EDK2, so I'll leave it to you. :) Sounds good. 😊 Thanks Abner > > Thanks, > > Michael -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112994): https://edk2.groups.io/g/devel/message/112994 Mute This Topic: https://groups.io/mt/103368438/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
