> I have realised that this was already fixed (i.e. allowing keeping the > warning) in Acidanthera fork of EDK-II. Discussed here > https://bugzilla.tianocore.org/show_bug.cgi?id=3704 - includes the fix > in question and other fixes for newer gcc as well. I'll post a new > patch to the list proposing just the relevant fix for clang.
I'm discussing this with the Acidanthera authors, and coming round to prefer the version proposed above, with no pragmas, actually. I think Ard is saying that, while I misdescribed somewhat when things would be optimised away, that they will be optimised away, and that probably the object files wouldn't be polluted, with this version? I'm running some further tests to confirm that the simple version proposed above builds in all the Acidanthera test environments, which is relevant in that it should rule out at least any obvious problems with it building in all edk-2 environments, too. (I had already run quick tests for CLANGDWARF, CLANGPDB and GCC RELEASE in edk2, with no problems.) If there aren't any issues there, I'd prefer to submit a patch for this simple version instead (combined with removing the -Wno-unneeded-internal-declaration for clangdwarf). -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112385): https://edk2.groups.io/g/devel/message/112385 Mute This Topic: https://groups.io/mt/103087794/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-