> +  //
> +  // Work around shim's terminally broken use of the EFI memory attributes
> +  // protocol, by uninstalling it if requested on the QEMU command line.
> +  //
> +  // E.g.,
> +  //       -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y
> +  //
> +  // This is only needed on the first boot, when fbaa64.efi is being invoked 
> to
> +  // set the boot order variables. Subsequent boots involving GRUB are not
> +  // affected.
> +  //
> +  Uninstall = FixedPcdGetBool (PcdUninstallMemAttrProtocol);
> +  QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol", 
> &Uninstall);
> +  if (Uninstall) {
> +    UninstallEfiMemoryAttributesProtocol ();
> +  }

Can we please have a log message here, for both uninstall and
keep-installed cases?

Otherwise the patch looks good to me.

thanks,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112290): https://edk2.groups.io/g/devel/message/112290
Mute This Topic: https://groups.io/mt/103106391/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to