Reviewed-by: Nickle Wang <nick...@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: abner.ch...@amd.com <abner.ch...@amd.com>
> Sent: Monday, November 27, 2023 1:31 PM
> To: devel@edk2.groups.io
> Cc: Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>;
> Mike Maslenkin <mike.maslen...@gmail.com>
> Subject: [PATCH V3 7/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect
> reference of MAC address pointer
>
> External email: Use caution opening links or attachments
>
>
> From: Abner Chang <abner.ch...@amd.com>
>
> MAC address reference is incorrect when it is copied to Host Interface
> DeviceDescriptor.
>
> Signed-off-by: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Cc: Mike Maslenkin <mike.maslen...@gmail.com>
> ---
> .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> index e5bf70cfd58..c4a71226e63 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> +++ nterfaceBmcUsbNicLib.c
> @@ -120,7 +120,7 @@ RedfishPlatformHostInterfaceDeviceDescriptor (
> InterfaceData->DeviceDescriptor.UsbDeviceV2.SerialNumberStr = 0;
> CopyMem (
> (VOID *)&InterfaceData->DeviceDescriptor.UsbDeviceV2.MacAddress,
> - (VOID *)&ThisInstance->MacAddress,
> + (VOID *)ThisInstance->MacAddress,
> sizeof (InterfaceData->DeviceDescriptor.UsbDeviceV2.MacAddress)
> );
> InterfaceData->DeviceDescriptor.UsbDeviceV2.Characteristics
> |=
> (UINT16)ThisInstance->CredentialBootstrapping;
> --
> 2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112014): https://edk2.groups.io/g/devel/message/112014
Mute This Topic: https://groups.io/mt/102824322/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
