Reviewed-by: Nickle Wang <nick...@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <mike.maslen...@gmail.com>
> Sent: Friday, December 1, 2023 7:19 AM
> To: devel@edk2.groups.io
> Cc: abner.ch...@amd.com; Nickle Wang <nick...@nvidia.com>;
> ig...@ami.com
> Subject: [PATCH 1/3] RedfishClientPkg: fix misleading texts in debug traces.
>
> External email: Use caution opening links or attachments
>
>
> Update debug traces with the correct function names.
>
> Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> ---
> RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++--
> .../ComputerSystem/v1_5_0/Common/ComputerSystemCommon.c | 4 ++--
> RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c | 4
> ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> index ea2740184160..a26a1083cd74 100644
> --- a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
> @@ -553,7 +553,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -720,7 +720,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> diff --git
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> index 78beb5cb32b3..979d49f79234 100644
> ---
> a/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> +++
> b/RedfishClientPkg/Features/ComputerSystem/v1_5_0/Common/ComputerSyste
> mCommon.c
> @@ -1457,7 +1457,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -1591,7 +1591,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> diff --git
> a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> index 44325ddb21c4..14c263011c2a 100644
> --- a/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> +++ b/RedfishClientPkg/Features/Memory/V1_7_1/Common/MemoryCommon.c
> @@ -2373,7 +2373,7 @@ RedfishCheckResourceCommon (
>
> Status = RedfishPlatformConfigGetConfigureLang (RESOURCE_SCHEMA,
> RESOURCE_SCHEMA_VERSION, REDPATH_ARRAY_PATTERN, &ConfigureLangList,
> &Count);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a, RedfishPlatformConfigGetConfigureLang
> failed: %r\n", __func__, Status));
> return Status;
> }
>
> @@ -2507,7 +2507,7 @@ RedfishIdentifyResourceCommon (
> if (Supported) {
> Status = RedfishFeatureGetUnifiedArrayTypeConfigureLang
> (RESOURCE_SCHEMA, RESOURCE_SCHEMA_VERSION,
> REDPATH_ARRAY_PATTERN, &ConfigLangList);
> if (EFI_ERROR (Status)) {
> - DEBUG ((DEBUG_ERROR, "%a, BiosConfigToRedfishGetConfigureLangRegex
> failed: %r\n", __func__, Status));
> + DEBUG ((DEBUG_ERROR, "%a,
> RedfishFeatureGetUnifiedArrayTypeConfigureLang failed: %r\n", __func__,
> Status));
> return Status;
> }
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112004): https://edk2.groups.io/g/devel/message/112004
Mute This Topic: https://groups.io/mt/102905309/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-