Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
Thanks, Chasel > -----Original Message----- > From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> > Sent: Thursday, November 30, 2023 4:06 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Ni, Ray <ray...@intel.com>; > Chaganty, > Rangasai V <rangasai.v.chaga...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Kinney, Michael D <michael.d.kin...@intel.com>; > Taylor Beebe <taylor.d.be...@gmail.com>; Kubacki, Michael > <michael.kuba...@microsoft.com> > Subject: [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build > Failures > > Commit 7284c44 in edk2 introduces an incompatibility that causes any project > that uses DxeMain.inf to fail to build. This is due to the addition of > ImagePropertiesRecordLib, and a new added dependency on that library in > DxeMain. Platforms will not have this LibraryClass defined in their DSC yet > and > hence currently fail to build. > > This changes addes ImagePropertiesRecordLib to CoreCommonLib.dsc, which will > be picked up by all platforms that adhere to the MinPlatform Architecture. > This > will fix most Intel platform builds in edk2-platforms. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Taylor Beebe <taylor.d.be...@gmail.com> > Cc: Michael Kubacki <michael.kuba...@microsoft.com> > Signed-off-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > --- > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index 300b7d7652..e40b2ff6e1 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -174,3 +174,4 @@ > > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVari > ableFlashInfoLib.inf > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variabl > ePolicyHelperLib.inf > + > + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib > + /ImagePropertiesRecordLib.inf > -- > 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111926): https://edk2.groups.io/g/devel/message/111926 Mute This Topic: https://groups.io/mt/102906021/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
