Hi Laszlo, Thanks for your support too! By the way, do we still plan to remove LgacyBiosMpTable.h? We can follow up with relevant OpenBoardPkg fixes if that's the goal.
Thanks, Chasel > -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Thursday, November 23, 2023 2:05 AM > To: devel@edk2.groups.io; Chiu, Chasel <chasel.c...@intel.com> > Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, Nathaniel > L <nathaniel.l.desim...@intel.com> > Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove <LegacyBiosMpTable.h> references > > Hi Chasel, > > On 11/21/23 03:17, Chiu, Chasel wrote: > > > > Hi Laszlo, > > > > I think you have to clone all the required repos. > > edk2 repository > > git clone https://github.com/tianocore/edk2.git > > > > edk2-platforms repository > > git clone https://github.com/tianocore/edk2-platforms.git > > > > edk2-non-osi repository > > git clone https://github.com/tianocore/edk2-non-osi.git > > > > FSP repository > > git clone https://github.com/IntelFsp/FSP.git > > But that's the thing exactly: this repository is not public, and I'm not a > member of > the IntelFsp organization. When I log in to GitHub, and open > > https://github.com/IntelFsp/ > > the page says > > This organization has no public repositories. > > This is basically what I meant earlier, when I asked: "How can I satisfy the > FSP > blob requirement?". > > Anyway... this is taking too long; I don't want to waste your time with it. > We can't > reasonably expect any contributor to send patches for a subsystem they can't > even build due to not being permitted access to various proprietary blobs. I'm > dropping this patch set now (for edk2 as well), and removing myself from the > BZ. > > Thanks for the help thus far! > Laszlo > > > > > check if you got all repos like below: > > edk2 > > edk2-non-osi > > edk2-platforms > > FSP > > > > Then switch to edk2-platforms/Platform/Intel/build_bios.py -p > > WilsonCityRvp to start the build > > > > Detail information is in readme: > > https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel > > /Readme.md > > > > Please let me know if any question. > > > > Thanks, > > Chasel > > > > > > > > > > > >> -----Original Message----- > >> From: Laszlo Ersek <ler...@redhat.com> > >> Sent: Wednesday, November 15, 2023 3:51 AM > >> To: devel@edk2.groups.io; Chiu, Chasel <chasel.c...@intel.com> > >> Cc: Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Desimone, > >> Nathaniel L <nathaniel.l.desim...@intel.com> > >> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > >> remove <LegacyBiosMpTable.h> references > >> > >> Hi Chasel, > >> > >> On 11/10/23 02:13, Chiu, Chasel wrote: > >>> > >>> Hi Laszlo, > >>> > >>> I verified and encountered build failure as some files still > >>> consuming definitions > >> from LegacyBiosMpTable.h, for example: > >>> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513 > >>> 38 > >>> > >> > 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co > >> m > >>> mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22 > >>> > >>> Any suggestion that we can reduce impact to existing platforms? > >> > >> I've been hoping to get comments from Nate on the expected contents > >> of DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my > proposal: > >> I'd like to just replace the enum constants in question with their > >> numerical > values. > >> > >> However, even for that, I'd really like to be able to build-test the > >> platform > locally. > >> Do you have build instructions? How can I satisfy the FSP blob requirement? > >> > >> Thanks! > >> Laszlo > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111754): https://edk2.groups.io/g/devel/message/111754 Mute This Topic: https://groups.io/mt/102483850/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
