Related to https://bugzilla.tianocore.org/show_bug.cgi?id=4121, but not resolving it. (Nearly?) all of ArmPkg describes industry standard behaviour, and hence according to general rules, ought to live in MdePkg.
Addressing this will however be a substantial task. Take a first step by moving the ArmLib interface definition to MdePkg, as discussed in https://edk2.groups.io/g/devel/topic/patch_v5_2_6/102725178 Cc: Pierre Gondois <pierre.gond...@arm.com> Cc: Jiewen Yao <jiewen....@intel.com> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Michael D Kinney <michael.d.kin...@intel.com> Cc: Sami Mujawar <sami.muja...@arm.com> Cc: Zhiguang Liu <zhiguang....@intel.com> Signed-off-by: Leif Lindholm <quic_llind...@quicinc.com> --- This should have no functional differences (and the set of platforms I have test built didn't find any problems). This may result in some modules depending on ArmPkg only for ArmLib now being able to drop ArmPkg dependency. ArmPkg/ArmPkg.dec | 4 ---- MdePkg/MdePkg.dec | 5 +++++ {ArmPkg => MdePkg}/Include/Library/ArmLib.h | 0 Maintainers.txt | 6 ++++++ 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index 7fe2b9bca43b..4ce59f3e1fbd 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -50,10 +50,6 @@ [LibraryClasses.common] # ArmHvcLib|Include/Library/ArmHvcLib.h - ## @libraryclass Provides an interface to Arm registers. - # - ArmLib|Include/Library/ArmLib.h - ## @libraryclass Provides a Mmu interface. # ArmMmuLib|Include/Library/ArmMmuLib.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ac54338089e8..78e18ee444cd 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -339,6 +339,11 @@ [LibraryClasses.RISCV64] ## @libraryclass Provides function to make ecalls to SBI BaseRiscVSbiLib|Include/Library/BaseRiscVSbiLib.h +[LibraryClasses.ARM, LibraryClasses.AARCH64] + ## @libraryclass Provides an interface to Arm registers. + # + ArmLib|Include/Library/ArmLib.h + [Guids] # # GUID defined in UEFI2.1/UEFI2.0/EFI1.1 diff --git a/ArmPkg/Include/Library/ArmLib.h b/MdePkg/Include/Library/ArmLib.h similarity index 100% rename from ArmPkg/Include/Library/ArmLib.h rename to MdePkg/Include/Library/ArmLib.h diff --git a/Maintainers.txt b/Maintainers.txt index 7c0b4cb58cfd..0315fa23dfce 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -450,6 +450,12 @@ M: Abner Chang <abner.ch...@amd.com> [changab] R: Abdul Lateef Attar <abdullateef.at...@amd.com> [abdattar] R: Nickle Wang <nick...@nvidia.com> [nicklela] +MdePkg: ARM/AARCH64 standard interfaces +F: MdePkg/Include/Library/ArmLib.h +M: Leif Lindholm <quic_llind...@quicinc.com> [leiflindholm] +M: Ard Biesheuvel <ardb+tianoc...@kernel.org> [ardbiesheuvel] +R: Sami Mujawar <sami.muja...@arm.com> [samimujawar] + NetworkPkg F: NetworkPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg -- 2.30.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111566): https://edk2.groups.io/g/devel/message/111566 Mute This Topic: https://groups.io/mt/102731845/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-