Cool, thanks for considering that! > -----Original Message----- > From: Ard Biesheuvel <a...@kernel.org> > Sent: Wednesday, November 22, 2023 12:03 AM > To: devel@edk2.groups.io; quic_llind...@quicinc.com > Cc: Yao, Jiewen <jiewen....@intel.com>; Pierre Gondois > <pierre.gond...@arm.com>; Li, Yi1 <yi1...@intel.com>; Lu, Xiaoyu1 > <xiaoyu1...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>; Ard > Biesheuvel <ardb+tianoc...@kernel.org>; Sami Mujawar > <sami.muja...@arm.com>; Gerd Hoffmann <kra...@redhat.com> > Subject: Re: [edk2-devel] [PATCH v5 2/6] CryptoPkg/CryptoPkg.ci.yaml: Allow > dependency upon ArmPkg > > On Tue, 21 Nov 2023 at 10:55, Leif Lindholm <quic_llind...@quicinc.com> wrote: > > > > On Tue, Nov 21, 2023 at 14:46:05 +0000, Yao, Jiewen wrote: > > > This Bugzilla is filed in 2022-10-26. Now it is 2023-11-21. > > > > Oh, I'm sure I voiced the same opinion for many years before someone > > (rightly) told me to go gile that bugzilla. > > > > > I agree with you that it is a big task. May I know what is the plan? > > > E.g. who is working on that? When do you expect it will be done? > > > > On my list of "big items" to deal with, this comes after github PR > > migration and line-ending conversion. > > > > > According to the dependency rule, what we need is only *interface* > > > definition, but not *implementation*. > > > That means the really requirement here is to move *interface* from > > > ArmPkg to MdePkg, you can still keep the library implementation in > > > ArmPkg. (It is just a subset of this Bugzilla) > > > > That ... is an option I had not previously considered. > > Long-term we would still like to smash ArmLib into BaseLib, but if > > MdePkg maintainers would be OK with moving ArmLib.h into MdePkg... > > > > > Also, I don’t think CPUID check really matters here - since it is only > implementation. > > > As long as, you have interface in MdePkg, then your INF can declare that > interface. > > > You can still put real implementation in ArmPkg - no requirement to move. > > > That benefit is that you don’t need to add ArmPkg dependency in yaml. > > > > I can spin up a patch for that to get merged shortly after stable tag > > to give plenty of time to catch any issues that may arise from moving > > such a fundamental file. (These would likely be bugs, but > > nevertheless...) > > > > This sounds like a reasonable solution to me for the short term.
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111563): https://edk2.groups.io/g/devel/message/111563 Mute This Topic: https://groups.io/mt/102725178/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
