Sami: I have merged it. Please check. Thanks Liming > -----邮件原件----- > 发件人: [email protected] <[email protected]> 代表 Sami > Mujawar > 发送时间: 2023年11月21日 19:57 > 收件人: gaoliming <[email protected]>; 'Laszlo Ersek' > <[email protected]>; 'Michael Kinney' <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; Jeff Brasen ([email protected]) > <[email protected]> > 抄送: nd <[email protected]> > 主题: Re: 回复: edk2-stable202311: Re: [edk2-devel] [PATCH] > DynamicTablesPkg: Fix ETE _UID Creation > > Hi Liming, > > On 21/11/2023, 01:05, "gaoliming" <[email protected] > <mailto:[email protected]>> wrote: > > > Sami: > I am OK to merge this patch for this stable bug. I will add push label for > https://github.com/tianocore/edk2/pull/5061 > <https://github.com/tianocore/edk2/pull/5061> > [SAMI] Thank you for picking this patch for the stable tag. Apparently, the > patch does not seem to have merged. > I am not sure if you have already applied the push label. Please let me know > if > there are any issues that I can help with. > > Regards, > > Sami Mujawar > > Thanks > Liming > > -----邮件原件----- > > 发件人: Sami Mujawar <[email protected] > <mailto:[email protected]>> > > 发送时间: 2023年11月21日 0:07 > > 收件人: Laszlo Ersek <[email protected] <mailto:[email protected]>>; > Liming Gao (Byosoft address) > > <[email protected] <mailto:[email protected]>>; Michael > Kinney <[email protected] <mailto:[email protected]>>; > > [email protected] <mailto:[email protected]>; > [email protected] <mailto:[email protected]>; > [email protected] <mailto:[email protected]>; > > [email protected] <mailto:[email protected]>; > [email protected] <mailto:[email protected]> > > 抄送: [email protected] <mailto:[email protected]> > > 主题: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix > > ETE _UID Creation > > > > Hi Laszlo, Liming, Mike, > > > > Please see my response inline marked [SAMI]. > > > > Regards, > > > > Sami Mujawar > > > > On 17/11/2023 09:20 am, Laszlo Ersek wrote: > > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > > >> Just like CPU _UID, ETE UID also needs to be unique so > > >> use AcpiProcessorUid instead of CpuName > > >> > > >> Signed-off-by: Ashish Singhal <[email protected] > <mailto:[email protected]>> > > >> --- > > >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 > > ++++- > > >> 1 file changed, 4 insertions(+), 1 deletion(-) > > > Is this a fixup for the recent feature > > > > > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > > > https://edk2.groups.io/g/devel/message/108996 > <https://edk2.groups.io/g/devel/message/108996> > > > > > > ? > > > > > > If so, then I *think* this qualifies to be merged during the hard > > > feature freeze (+Liming +Mike), but: > > > > [SAMI] I raised a bugzilla for this issue at > > https://bugzilla.tianocore.org/show_bug.cgi?id=4600 > <https://bugzilla.tianocore.org/show_bug.cgi?id=4600> > > > > and have also created a pull request at > > https://github.com/tianocore/edk2/pull/5061 > <https://github.com/tianocore/edk2/pull/5061>. > > > > This patch has also passed the CI checks when I did a draft pull request. > > > > I am not sure if I can apply the push label as we are in the code freeze > > stage. > > > > Can you advise on how to proceed, please? > > > > [/SAMI] > > > > > - I think we should have a "Fixes:" tag in the commit message (for > > > pointing out the commit that should have contained the code being > > > added/updated now) > > > > > > - I think we should have a BZ too (also linked into the commit message). > > > > > > Laszlo > > > > > > > > > > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111547): https://edk2.groups.io/g/devel/message/111547 Mute This Topic: https://groups.io/mt/102728858/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
