Sorry, I finished review on my local, but forgot if I gave R-B or not. For ShellPkg part: Reviewed-by: Zhichao Gao <zhichao....@intel.com>
Thanks, Zhichao > -----Original Message----- > From: Rohit Mathew <rohit.mat...@arm.com> > Sent: Monday, November 20, 2023 8:17 PM > To: devel@edk2.groups.io; Rohit Mathew <rohit.mat...@arm.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Thomas Abraham > <thomas.abra...@arm.com>; Sami Mujawar <sami.muja...@arm.com>; > James Morse <james.mo...@arm.com>; Ni, Ray <ray...@intel.com>; Gao, > Zhichao <zhichao....@intel.com>; nd <n...@arm.com> > Subject: RE: [edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser > > Hi, > > Gentle reminder on the series. > > Regards, > Rohit > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rohit > > Mathew via groups.io > > Sent: Monday, October 2, 2023 6:14 PM > > To: devel@edk2.groups.io > > Cc: Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao > > <gaolim...@byosoft.com.cn>; Thomas Abraham > <thomas.abra...@arm.com>; > > Sami Mujawar <sami.muja...@arm.com>; James Morse > > <james.mo...@arm.com>; Ray Ni <ray...@intel.com>; Zhichao Gao > > <zhichao....@intel.com> > > Subject: [edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser > > > > This series adds the following > > - definitions corresponding to MPAM ACPI 2.0 specification. > > - MPAM parser > > > > An MPAM ACPI table formulated using the newly added MPAM ACPI > > definitions were validated on the linux kernel tree at [1]. The same > > table was parsed via acpiview using the newly added parser. Certain > > aspects of the MPAM ACPI specification are still not implemented by > > the kernel tree. These aspects were verified only using acpiview. > > > > Changes since V1: > > - Addressed comments on MPAM ACPI definitions from Sami. > > - V1 did not incorporate the parser. V2 has this implemented. > > > > Changes since V2: > > - Addressed comments related to Interface/Link type defintions from > Sami. > > > > Changes since v3: > > - Addressed comments from Pierre > > > > Changes since v4: > > - Addressed comments from Sami regarding Parser. > > > > Changes can be found at: > > https://github.com/rohit-arm/edk2/tree/mpam_acpi > > > > CI results can be found at: > > https://github.com/tianocore/edk2/pull/4748 > > > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git/log/?h > > =mpa > > m/snapshot/v6.5-rc1 > > > > > > Rohit Mathew (6): > > MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification > > ShellPkg/AcpiView: Update field-validator prototype > > ShellPkg/AcpiView: Update print-formatter prototype > > ShellPkg: acpiview: Add routine to print 16 chars > > ShellPkg: acpiview: Add routines to print reserved fields > > ShellPkg/AcpiView: Add MPAM Parser > > > > MdePkg/Include/IndustryStandard/Acpi65.h > > | 7 +- > > MdePkg/Include/IndustryStandard/Mpam.h > > | 246 > ++++ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > > | > 199 > > ++- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h > > | > > 109 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Aest/AestParser.c > > | 36 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > > | 8 +- > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Erst/ErstParser.c > > | 28 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > > | 24 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > > | 14 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Hmat/HmatParser. > c > > | 12 +- > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > > | 32 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c > > | 18 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamPars > er > > .c | 1276 ++++++++++++++++++++ > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c > > | 56 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > > | 38 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > > | 14 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c > > | 14 +- > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c > > | 26 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > > dLib.c | 3 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > > dLib.inf | 3 +- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComman > > dLib.uni | 3 +- > > 21 files changed, 2033 insertions(+), 133 deletions(-) create mode > > 100644 MdePkg/Include/IndustryStandard/Mpam.h > > create mode 100644 > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Mpam/MpamPars > er > > .c > > > > -- > > 2.34.1 > > > > > > > > -=-=-=-=-=-= > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#109258): > > https://edk2.groups.io/g/devel/message/109258 > > Mute This Topic: https://groups.io/mt/101716889/6795330 > > Group Owner: devel+ow...@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [rohit.mat...@arm.com] > > -=-=-=-=-=-= > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111532): https://edk2.groups.io/g/devel/message/111532 Mute This Topic: https://groups.io/mt/102705915/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
