Hi Hongbin1, On Mon, May 29, 2023 at 02:39:38PM +0800, Zhang, Hongbin1 via groups.io wrote: > Some features like RAS need to use processor extended information > under smm, So add code to support it > > Signed-off-by: Hongbin1 Zhang <hongbin1.zh...@intel.com>
I got a ASSERT when booting edk2-stable202308 on a issue machine: ASSERT /home/joeyli/source_code-git/edk2/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c(1478): (Index != 0) || (LevelType == 0x01) And, the ASSERT can also be reproduced on edk2 master. After reverted this patch, the ASSERT is gone. I have filed a bug here: https://bugzilla.tianocore.org/show_bug.cgi?id=4598 I have put some tracing information on bugzilla. Thank a lot! Joey Lee > Cc: Eric Dong <eric.d...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Star Zeng <star.z...@intel.com> > Cc: Jiaxin Wu <jiaxin...@intel.com> > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index c0e368ea94..8311c3b9de 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -929,7 +929,7 @@ PiCpuSmmEntry ( > gSmmCpuPrivate->Operation[Index] = SmmCpuNone; > > if (Index < mNumberOfCpus) { > - Status = MpServices->GetProcessorInfo (MpServices, Index, > &gSmmCpuPrivate->ProcessorInfo[Index]); > + Status = MpServices->GetProcessorInfo (MpServices, Index | > CPU_V2_EXTENDED_TOPOLOGY, &gSmmCpuPrivate->ProcessorInfo[Index]); > ASSERT_EFI_ERROR (Status); > mCpuHotPlugData.ApicId[Index] = > gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId; > > -- > 2.37.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111242): https://edk2.groups.io/g/devel/message/111242 Mute This Topic: https://groups.io/mt/99209786/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
