REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593
get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers, reviewers, and lists by unconditionally appending lists returned from get_section_maintainers(). Cc: Rebecca Cran <rebe...@bsdio.com> Cc: Liming Gao <gaolim...@byosoft.com.cn> Cc: Bob Feng <bob.c.f...@intel.com> Cc: Yuwei Chen <yuwei.c...@intel.com> Cc: Leif Lindholm <quic_llind...@quicinc.com> Signed-off-by: Michael D Kinney <michael.d.kin...@intel.com> --- BaseTools/Scripts/GetMaintainer.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py index 081460451e9b..a887962dd1bd 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -113,12 +113,9 @@ def get_maintainers(path, sections, level=0): lists = [] for section in sections: tmp_maint, tmp_review, tmp_lists = get_section_maintainers(path, section) - if tmp_maint: - maintainers += tmp_maint - if tmp_review: - reviewers += tmp_review - if tmp_lists: - lists += tmp_lists + maintainers += tmp_maint + reviewers += tmp_review + lists += tmp_lists if not maintainers: # If no match found, look for match for (nonexistent) file -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111044): https://edk2.groups.io/g/devel/message/111044 Mute This Topic: https://groups.io/mt/102510791/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-