Thanks Laszlo, much appreciate all comments. I will check one by one for fix in next version. /Jiaxin
> -----Original Message----- > From: Laszlo Ersek <ler...@redhat.com> > Sent: Tuesday, November 7, 2023 7:01 PM > To: devel@edk2.groups.io; Wu, Jiaxin <jiaxin...@intel.com> > Cc: Dong, Eric <eric.d...@intel.com>; Ni, Ray <ray...@intel.com>; Zeng, Star > <star.z...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; Kumar, Rahul R > <rahul.r.ku...@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 7/7] UefiCpuPkg/PiSmmCpuDxeSmm: > Consume SmmCpuSyncLib > > On 11/3/23 16:30, Wu, Jiaxin wrote: > > There is the SmmCpuSyncLib Library class define the SMM CPU sync > > flow, which is aligned with existing SMM CPU driver sync behavior. > > This patch is to consume SmmCpuSyncLib instance directly. > > > > With this change, SMM CPU Sync flow/logic can be customized > > with different implementation no matter for any purpose, e.g. > > performance tuning, handle specific register, etc. > > > > Change-Id: Id034de47b85743c125f0d76420947e0dd9e69518 > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Zeng Star <star.z...@intel.com> > > Cc: Gerd Hoffmann <kra...@redhat.com> > > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > Signed-off-by: Jiaxin Wu <jiaxin...@intel.com> > > --- > > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 256 +++++---------------- > ------ > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 6 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 1 + > > 3 files changed, 49 insertions(+), 214 deletions(-) > > I'll first review this in the v2 posting. > > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110843): https://edk2.groups.io/g/devel/message/110843 Mute This Topic: https://groups.io/mt/102366305/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
