Reviewed-by: Michael D Kinney <michael.d.kin...@intel.com>

> -----Original Message-----
> From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com>
> Sent: Thursday, November 2, 2023 8:59 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <af...@apple.com>; Laszlo Ersek <ler...@redhat.com>;
> Leif Lindholm <quic_llind...@quicinc.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>; Pedro Falcato <pedro.falc...@gmail.com>;
> Sean Brogan <sean.bro...@microsoft.com>
> Subject: [PATCH v2 1/1] ReadMe.rst: Add Apache License 2.0 and update
> submodule list
> 
> From: Michael Kubacki <michael.kuba...@microsoft.com>
> 
> - Adds Apache License 2.0 as an acceptable source license per
>   discussion in https://edk2.groups.io/g/devel/message/110226
> - Updates the URL for existing licenses to match the current path
>   used by opensource.org.
> - The submodule list in this file is stale and is very prone to
>   being forgotten. The list of submodules in the submodules setion
>   is replaced with a link to .gitmodules which has an active list
>   of submodules at any given time.
> 
> Cc: Andrew Fish <af...@apple.com>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Cc: Leif Lindholm <quic_llind...@quicinc.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Pedro Falcato <pedro.falc...@gmail.com>
> Cc: Sean Brogan <sean.bro...@microsoft.com>
> Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
> Reviewed-by: Laszlo Ersek <ler...@redhat.com>
> Acked-by: Pedro Falcato <pedro.falc...@gmail.com>
> ---
> 
> Notes:
>     v2 changes:
> 
>     - Add R-b and A-b tags
>     - Update exisitng license URLs from http to https
>     - Rework submodule section to remove unnecessary text and
>       move the ArmSoftFloatLib note to the bottom of the section.
> 
>  ReadMe.rst | 31 ++++++++------------
>  1 file changed, 13 insertions(+), 18 deletions(-)
> 
> diff --git a/ReadMe.rst b/ReadMe.rst
> index ed1d4822459b..06fb122ef382 100644
> --- a/ReadMe.rst
> +++ b/ReadMe.rst
> @@ -134,11 +134,12 @@ To make a contribution to a TianoCore project,
> follow these steps.
>      copyright license as the base project. When that is not possible,
>      then contributions using the following licenses can be accepted:
> 
> --  BSD (2-clause): http://opensource.org/licenses/BSD-2-Clause
> --  BSD (3-clause): http://opensource.org/licenses/BSD-3-Clause
> --  MIT: http://opensource.org/licenses/MIT
> --  Python-2.0: http://opensource.org/licenses/Python-2.0
> --  Zlib: http://opensource.org/licenses/Zlib
> +-  Apache License, Version 2.0:
> https://opensource.org/license/apache-2-0/
> +-  BSD (2-clause): https://opensource.org/license/BSD-2-Clause
> +-  BSD (3-clause): https://opensource.org/license/BSD-3-Clause
> +-  MIT: https://opensource.org/license/MIT
> +-  Python-2.0: https://opensource.org/license/Python-2.0
> +-  Zlib: https://opensource.org/license/Zlib
> 
>  For documentation:
> 
> @@ -243,19 +244,7 @@ Definitions for sample patch email
>  Submodules
>  ----------
> 
> -Submodule in EDK II is allowed but submodule chain should be avoided
> -as possible as we can. Currently EDK II contains the following
> submodules
> -
> --  CryptoPkg/Library/OpensslLib/openssl
> --  ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> --  MdeModulePkg/Universal/RegularExpressionDxe/oniguruma
> --  MdeModulePkg/Library/BrotliCustomDecompressLib/brotli
> --  BaseTools/Source/C/BrotliCompress/brotli
> -
> -ArmSoftFloatLib is actually required by OpensslLib. It's inevitable
> -in openssl-1.1.1 (since stable201905) for floating point parameter
> -conversion, but should be dropped once there's no such need in future
> -release of openssl.
> +The current submodules used in EDK II are in `.gitmodules
> <.gitmodules>`__.
> 
>  To get a full, buildable EDK II repository, use following steps of
> git
>  command
> @@ -283,6 +272,12 @@ dependency on being able to reach servers we do
> not actually want
>  any code from, as well as needlessly downloading code we will not
>  use.
> 
> +**Submodule Notes**
> +
> +ArmSoftFloatLib is required by OpensslLib. It's inevitable in
> openssl-1.1.1
> +(since stable201905) for floating point parameter conversion, but
> should be
> +dropped once there's no such need in future release of openssl.
> +
>  ..
> ===================================================================
>  .. This is a bunch of directives to make the README file more
> readable
>  ..
> ===================================================================
> --
> 2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110563): https://edk2.groups.io/g/devel/message/110563
Mute This Topic: https://groups.io/mt/102345483/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to