[AMD Official Use Only - General] Sure, thanks for this change.
Reviewed-by: Abner Chang <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> From: Nickle Wang <nick...@nvidia.com> Sent: Wednesday, November 1, 2023 8:53 AM To: Mike Maslenkin <mike.maslen...@gmail.com>; devel@edk2.groups.io; Chang, Abner <abner.ch...@amd.com> Cc: Igor Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> Subject: RE: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions. Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > Ack. > Looks good to me. Thanks for your review, Mike! @Abner Chang<mailto:abner.ch...@amd.com>, could you please provide reviewed-by to version 3 if this looks good to you? Regards, Nickle > -----Original Message----- > From: Mike Maslenkin > <mike.maslen...@gmail.com<mailto:mike.maslen...@gmail.com>> > Sent: Tuesday, October 31, 2023 11:14 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Nickle Wang > <nick...@nvidia.com<mailto:nick...@nvidia.com>> > Cc: Abner Chang <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Igor > Kulchytskyy <ig...@ami.com<mailto:ig...@ami.com>>; > Nick Ramirez <nrami...@nvidia.com<mailto:nrami...@nvidia.com>> > Subject: Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple > definitions. > > External email: Use caution opening links or attachments > > > On Tue, Oct 31, 2023 at 3:56 PM Nickle Wang via groups.io > <nicklew=nvidia....@groups.io<mailto:nicklew=nvidia....@groups.io>> wrote: > > > > There are two definitions for below functions in RedfishCrtLib.h. > > Create this change to remote duplicated functions. > > Function list: strcmp(), strncmp(), strncpy(), strcpy(), strcat(), > > strlen(), strchr(), strcasecmp(), strstr(), memcmp(), memset(), > > memcpy(), memchr(), memcmp() and memmove(). > > > > Signed-off-by: Nickle Wang <nick...@nvidia.com<mailto:nick...@nvidia.com>> > > Cc: Abner Chang <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> > > Cc: Igor Kulchytskyy <ig...@ami.com<mailto:ig...@ami.com>> > > Cc: Nick Ramirez <nrami...@nvidia.com<mailto:nrami...@nvidia.com>> > > Cc: Mike Maslenkin > > <mike.maslen...@gmail.com<mailto:mike.maslen...@gmail.com>> > > Reviewed-by: Abner Chang <abner.ch...@amd.com<mailto:abner.ch...@amd.com>> > > --- > > RedfishPkg/Include/Library/RedfishCrtLib.h | 105 > > --------------------- > > 1 file changed, 105 deletions(-) > > > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h > > b/RedfishPkg/Include/Library/RedfishCrtLib.h > > index 23c6acfca33e..ac6c5162ad6a 100644 > > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > > @@ -172,20 +172,6 @@ free ( > > void * > > ); > > > > -void * > > -memset ( > > - void *, > > - int, > > - size_t > > - ); > > - > > -int > > -memcmp ( > > - const void *, > > - const void *, > > - size_t > > - ); > > - > > int > > isdigit ( > > int > > @@ -216,47 +202,6 @@ isalnum ( > > int > > ); > > > > -void * > > -memcpy ( > > - void *, > > - const void *, > > - size_t > > - ); > > - > > -void * > > -memset ( > > - void *, > > - int, > > - size_t > > - ); > > - > > -void * > > -memchr ( > > - const void *, > > - int, > > - size_t > > - ); > > - > > -int > > -memcmp ( > > - const void *, > > - const void *, > > - size_t > > - ); > > - > > -void * > > -memmove ( > > - void *, > > - const void *, > > - size_t > > - ); > > - > > -int > > -strcmp ( > > - const char *, > > - const char * > > - ); > > - > > int > > strncmp ( > > const char *, > > @@ -264,35 +209,6 @@ strncmp ( > > size_t > > ); > > > > -char * > > -strcpy ( > > - char *, > > - const char * > > - ); > > - > > -size_t > > -strlen ( > > - const char * > > - ); > > - > > -char * > > -strcat ( > > - char *, > > - const char * > > - ); > > - > > -char * > > -strchr ( > > - const char *, > > - int > > - ); > > - > > -int > > -strcasecmp ( > > - const char *, > > - const char * > > - ); > > - > > int > > strncasecmp ( > > const char *, > > @@ -300,21 +216,6 @@ strncasecmp ( > > size_t > > ); > > > > -char * > > -strncpy ( > > - char *, > > - size_t, > > - const char *, > > - size_t > > - ); > > - > > -int > > -strncmp ( > > - const char *, > > - const char *, > > - size_t > > - ); > > - > > char * > > strrchr ( > > const char *, > > @@ -328,12 +229,6 @@ strtoul ( > > int > > ); > > > > -char * > > -strstr ( > > - const char *s1, > > - const char *s2 > > - ); > > - > > long > > strtol ( > > const char *, > > -- > > 2.17.1 > > Ack. > Looks good to me. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110461): https://edk2.groups.io/g/devel/message/110461 Mute This Topic: https://groups.io/mt/102296237/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
